Your plugin doesn´t work with my IntelliJ Setup

8:53:31 PM PluginException: pl/charmas/parcelablegenerator/ParcelableAction : Unsupported major.minor version 51.0 [Plugin: pl.charmas.parcelablegenerator]: pl/charmas/parcelablegenerator/ParcelableAction : Unsupported major.minor version 51.0 [Plugin: pl.charmas.parcelablegenerator]

I´m using the latest intelliJ:

I am having issues with List support. I keep getting NullPointers when I try to read my object. Below is the objects involed:

Root object I am trying to parcel

public class MyObjectToStore implements Parcelable {
    public List<ObjectInList> objectsInList;
    public String myObjectValue;

    public MyObjectToStore() {
    }

    private MyObjectToStore(Parcel in) {
        in.readTypedList(objectsInList, ObjectInList.CREATOR);
        this.myObjectValue = in.readString();
    }

    @Override
    public void writeToParcel(Parcel dest, int flags) {
        dest.writeTypedList(objectsInList);
        dest.writeString(this.myObjectValue);
    }

    @Override
    public int describeContents() {
        return 0;
    }

    public static final Creator<MyObjectToStore> CREATOR = new Creator<MyObjectToStore>() {
        public MyObjectToStore createFromParcel(Parcel source) {
            return new MyObjectToStore(source);
        }

        public MyObjectToStore[] newArray(int size) {
            return new MyObjectToStore[size];
        }
    };
}

Inner Parcelable in list

public class ObjectInList implements Parcelable {
    String objectInListValue;

    private ObjectInList(Parcel in) {
        this.objectInListValue = in.readString();
    }

    public ObjectInList(String objectInListValue) {
        this.objectInListValue = objectInListValue;
    }

    @Override
    public void writeToParcel(Parcel dest, int flags) {
        dest.writeString(this.objectInListValue);
    }

    @Override
    public int describeContents() {
        return 0;
    }

    public static final Creator<ObjectInList> CREATOR = new Creator<ObjectInList>() {
        public ObjectInList createFromParcel(Parcel source) {
            return new ObjectInList(source);
        }

        public ObjectInList[] newArray(int size) {
            return new ObjectInList[size];
        }
    };
}

Test that shows Exception

public class MyObjectToStoreTest extends TestCase {

    public void testParcelable() {
        MyObjectToStore objectToStore = new MyObjectToStore();
        objectToStore.myObjectValue = "MyObjectValue";
        List<ObjectInList> list = new ArrayList<ObjectInList>();
        list.add(new ObjectInList("Object1"));
        list.add(new ObjectInList("Object2"));
        objectToStore.objectsInList = list;

        Parcel parcel = Parcel.obtain();
        objectToStore.writeToParcel(parcel, 0);
        parcel.setDataPosition(0);

        MyObjectToStore fromParcel = MyObjectToStore.CREATOR.createFromParcel(parcel);
        assertEquals("MyObjectValue", fromParcel.myObjectValue);
        assertEquals(2, fromParcel.objectsInList.size());
        assertEquals("Object1", fromParcel.objectsInList.get(0).objectInListValue);
        assertEquals("Object2", fromParcel.objectsInList.get(1).objectInListValue);
    }
}

Exception

java.lang.NullPointerException
at android.os.Parcel.readTypedList(Parcel.java:1797)
at objects.MyObjectToStore.<init>(MyObjectToStore.java:27)
at objects.MyObjectToStore.<init>(MyObjectToStore.java:8)
at objects.MyObjectToStore$1.createFromParcel(MyObjectToStore.java:33)
at objects.MyObjectToStore$1.createFromParcel(MyObjectToStore.java:31)
at objects.MyObjectToStoreTest.testParcelable(MyObjectToStoreTest.java:24)

It seems to blow up because the list in MyObjectToStore is not being initialized properly by the generated code in private MyObjectToStore(Parcel in). Shouldn't that constructor generate something like

private MyObjectToStore(Parcel in) {
    objectsInList = new ArrayList<ObjectInList>(); // new
    in.readTypedList(objectsInList, ObjectInList.CREATOR);
    this.myObjectValue = in.readString();
}

Am I missing something? Is this an unimplemented feature, a bug, or a compromise because the code generator doesn't know what Type of list it is?

I got this

null
java.lang.NullPointerException
    at pl.charmas.parcelablegenerator.util.PsiUtils.isOfType(PsiUtils.java:42)
    at pl.charmas.parcelablegenerator.typeserializers.ParcelableSerializerFactory.getSerializer(ParcelableSerializerFactory.java:35)
    at pl.charmas.parcelablegenerator.typeserializers.ChainSerializerFactory.getSerializer(ChainSerializerFactory.java:35)
    at pl.charmas.parcelablegenerator.CodeGenerator.getSerializerForType(CodeGenerator.java:131)
    at pl.charmas.parcelablegenerator.CodeGenerator.generateWriteToParcel(CodeGenerator.java:107)
    at pl.charmas.parcelablegenerator.CodeGenerator.generate(CodeGenerator.java:146)
    at pl.charmas.parcelablegenerator.ParcelableAction$1.run(ParcelableAction.java:50)
    at com.intellij.openapi.command.WriteCommandAction$Simple.run(WriteCommandAction.java:166)
    at com.intellij.openapi.application.RunResult.run(RunResult.java:35)
    at com.intellij.openapi.command.WriteCommandAction$2$1.run(WriteCommandAction.java:114)
    at com.intellij.openapi.application.impl.ApplicationImpl.runWriteAction(ApplicationImpl.java:1010)
    at com.intellij.openapi.command.WriteCommandAction$2.run(WriteCommandAction.java:111)
    at com.intellij.openapi.command.impl.CoreCommandProcessor.executeCommand(CoreCommandProcessor.java:124)
    at com.intellij.openapi.command.impl.CoreCommandProcessor.executeCommand(CoreCommandProcessor.java:99)
    at com.intellij.openapi.command.WriteCommandAction.performWriteCommandAction(WriteCommandAction.java:108)
    at com.intellij.openapi.command.WriteCommandAction.execute(WriteCommandAction.java:80)
    at pl.charmas.parcelablegenerator.ParcelableAction.generateParcelable(ParcelableAction.java:47)
    at pl.charmas.parcelablegenerator.ParcelableAction.actionPerformed(ParcelableAction.java:42)
    at com.intellij.ui.popup.PopupFactoryImpl$ActionPopupStep.performAction(PopupFactoryImpl.java:856)
    at com.intellij.ui.popup.PopupFactoryImpl$ActionPopupStep$1.run(PopupFactoryImpl.java:842)
    at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)
    at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:756)
    at java.awt.EventQueue.access$500(EventQueue.java:97)
    at java.awt.EventQueue$3.run(EventQueue.java:709)
    at java.awt.EventQueue$3.run(EventQueue.java:703)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
    at java.awt.EventQueue.dispatchEvent(EventQueue.java:726)
    at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:866)
    at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:654)
    at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:381)
    at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
    at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
    at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
    at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
    at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
    at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

when i try use plugin for my class

public abstract class SimpleAdapter<T> extends BaseAdapter implements Parcelable {
    public List<T> items;
    public Context context;

    public SimpleAdapter(List<T> items, Context context) {
        this.items = items;
        this.context = context;
    }

    @Override
    public int getCount() {
        return items.size();
    }

    @Override
    public Object getItem(int position) {
        return items.get(position);
    }

    @Override
    public long getItemId(int position) {
        return position;
    }

    public View generateView(int viewId, ViewGroup parent){
        LayoutInflater inflater = LayoutInflater.from(context);
        View view = inflater.inflate(viewId, parent, false);

        return view;
    }


}

Where I mistake?

Hello

i'm checking my project with checkstyle to find code related issues. It is warning me about this

public static final Parcelable.Creator CREATOR = new Parcelable.Creator() { public ComplaintData createFromParcel( Parcel source ) {return new ComplaintData(source);} public ComplaintData[] newArray( int size ) {return new ComplaintData[size];} };

with the following messages:

'return' is not preceded with whitespace. '{' is not followed by whitespace. ';' is not followed by whitespace. '}' is not preceded with whitespace.

Is it possible to fix this issues in the plugin ?

Thanks a lot

Just discovered that Short as a reference data type is not supported in this plugin.

I don't know what to do with primitive short. Parcel doesn't have a method for primitive short. There are three ways I can think of right now.

• Do a widening conversion to int? Kind of wasteful and there might not be compiler errors if data type gets changed.
• Autobox to Short?
• Just treat it as a Serializable?

I don't know. But this PR should be good for Short.

After upgraded to latest version 0.6.3, it seems I can no longer generate Parcelable in child classes regardless of what accessors those fields have.

For example:

public class Person {
    String name;
}

public class Employee extends Person {
    String company;
}

The Employee class can only generate Parcelable for its own fields, company but not name. It might make sense. But what if the parent class doesn't implement Parcelable at all and I only want child classes to implement Parcelable?

Is this a design change?

In release 0.6.1 generation for fields like private List<String> names; results in something like this:

    @Override
    public void writeToParcel(Parcel dest, int flags) {
        dest.writeList(this.names);
    }

    private Contact(Parcel in) {
        this.names = new ArrayList<List<String>>();
        in.readList(this.names, List<String>.class.getClassLoader());
    }

Which, obviously, does not compile. :) I suggest that for lists of strings you should use writeStringList() and readStringList(), for example:

    @Override
    public void writeToParcel(Parcel dest, int flags) {
        dest.writeStringList(this.names);
    }

    private Contact(Parcel in) {
        this.names = new ArrayList<String>();
        in.readStringList(this.names);
    }

Default proguard config don't obfuscate only public static final CREATOR fields. See file %ANDROID_HOME%/tools/proguard/proguard-android.txt:

-keep class * implements android.os.Parcelable {
  public static final android.os.Parcelable$Creator *;
}

Reason for change:

• I was building a library that required a set of pure-java value objects (sans android stuff), and an add-on android library that extended the main library that added Parcelable support.
• This PR also resolves https://github.com/mcharmas/android-parcelable-intellij-plugin/issues/35 and the cases described there.

Details:

• Added option to "Include fields from subclasses".
• Option uses psiClass.getAllFields() if checked, and psiClass.getFields() (as before) when unchecked/deselected.
• Option is unchecked by default.
• Option only appears if there are additional fields in subclasses.
• Also did some general refactoring of GenerateDialog.

Tested:

• Tested with large classes (Hundreds of fields).
• Tested with deeply nested classes.

Thank you very much for this nice plugin! In my opinion, the non param constructor for the generated class is necessary but the compiler maybe not able to detect this, so could we add SuppressWarning("unused") for the constructor? Thanks again for reading this issue.

Hello all,

I am sure there is a reason for this, but describeContents returns 0, why not return hashCode() instead?

Neither implementation is that helpful, but I would say hashCode() is better than 0.

What do you guys think?

Maybe use the "Parcelable support" of "Android Extensions plugin" :

https://blog.jetbrains.com/kotlin/2017/08/kotlin-1-1-4-is-out/

It could be great. Your plugin could just use it, and work as a nice UI to generate its code, choosing which fields to be stored&restored, and which not, and in which order, etc...

An example of usage, using this feature:

Gradle file :

apply plugin: 'org.jetbrains.kotlin.android.extensions' androidExtensions { experimental = true }

sample code of a class with 3 Dates in it:

@SuppressLint("ParcelCreator")
@Parcelize
class MonthItem(val today: Date, val startDate: Date, val endDate: Date) : Parcelable {
}

When I need to save a list of parcelable objects whose type has been subclassed, it doesn't save the members of the subclass.

class A {
  ArrayList<B> list;
  ...
}

class B {
  ...
}

class C extends B {
  // members in addition to members of class B that should be saved when saving list
}

This causes a difficult to trace RunTimeException when unparcelling the list. The RTE is something like

java.lang.RuntimeException: Parcel android.os.Parcel@XXX: Unmarshalling unknown type code YYY at offset ZZZ}

This happens because of the writeTypedArrayList method. I fixed the error by replacing this method with writeList and the readTypedArrayList method with readList as well.

Here is a larger writeup done by someone who experienced this same scenario without the plugin https://medium.com/@kcoppock/writing-parcelable-lists-with-inheritance-a739c42c055c