Hi,

I noticed that if you put the MKLoader inside a recycler view item, when the view holder is recycled the animation is stopped.

Can you look at the issue?

Thanks

Hello, i've found a little mistake which makes memory leaks. In each implementation of LoaderView you use invalidateListener in infinity ValueAnimator and it holds a context (yep, activity).

Easy solution: Add to MKLoader view: protected void onDetachedFromWindow() { super.onDetachedFromWindow(); loaderView.setInvalidateListener(null); }

and in each ValueAnimator check for invalidateListener == null and stop animations

Hi, I saw your library on Android Weekly — nice stuff. I thought I'd tweak the build a bit to make it easier to upgrade versions in the future — hope that's cool.

Fatal Exception: java.lang.NullPointerExceptionAttempt to read from field 'float android.graphics.PointF.x' on a null object reference Raw Text

  | com.tuyenmonkey.mkloader.type.ClassicSpinner.draw + 57 (ClassicSpinner.java:57)   | com.tuyenmonkey.mkloader.MKLoader.onDraw + 61 (MKLoader.java:61)   | android.view.View.draw + 20463 (View.java:20463)   | android.view.ViewGroup.dispatchDraw + 4170 (ViewGroup.java:4170)   | com.jeremyfeinstein.slidingmenu.lib.CustomViewAbove.dispatchDraw + 769 (CustomViewAbove.java:769)   | android.view.View.draw + 20466 (View.java:20466)   | com.android.internal.os.ZygoteInit.main + 958 (ZygoteInit.java:958)

The loader was running smoothly, unless I update the device with Android Pie update. Attaching log response for your reference.

Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'android.graphics.PointF com.tuyenmonkey.mkloader.model.Line.getPoint1()' on a null object reference at com.tuyenmonkey.mkloader.type.Pulse.draw(Pulse.java:67) at com.tuyenmonkey.mkloader.MKLoader.onDraw(MKLoader.java:61) at android.view.View.draw(View.java:20211) at android.view.View.updateDisplayListIfDirty(View.java:19086) at android.view.View.draw(View.java:19939) at android.view.ViewGroup.drawChild(ViewGroup.java:4333) at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4136) at android.view.View.updateDisplayListIfDirty(View.java:19077) at android.view.View.draw(View.java:19939) at android.view.ViewGroup.drawChild(ViewGroup.java:4333) at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4112) at android.view.View.updateDisplayListIfDirty(View.java:19077) at android.view.View.draw(View.java:19939) at android.view.ViewGroup.drawChild(ViewGroup.java:4333) at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4112) at android.view.View.draw(View.java:20214) at android.support.v4.view.ViewPager.draw(ViewPager.java:2420) at android.view.View.updateDisplayListIfDirty(View.java:19086) at android.view.View.draw(View.java:19939) at android.view.ViewGroup.drawChild(ViewGroup.java:4333) at android.support.design.widget.CoordinatorLayout.drawChild(CoordinatorLayout.java:1254) at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4112) at android.view.View.draw(View.java:20214) at android.view.View.updateDisplayListIfDirty(View.java:19086) at android.view.View.draw(View.java:19939) at android.view.ViewGroup.drawChild(ViewGroup.java:4333) at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4112) at android.view.View.updateDisplayListIfDirty(View.java:19077) at android.view.View.draw(View.java:19939) at android.view.ViewGroup.drawChild(ViewGroup.java:4333) at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4112) at android.view.View.updateDisplayListIfDirty(View.java:19077) at android.view.View.draw(View.java:19939) at android.view.ViewGroup.drawChild(ViewGroup.java:4333) at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4112) at android.view.View.updateDisplayListIfDirty(View.java:19077) at android.view.View.draw(View.java:19939) at android.view.ViewGroup.drawChild(ViewGroup.java:4333) at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4112) at android.view.View.updateDisplayListIfDirty(View.java:19077) at android.view.View.draw(View.java:19939) at android.view.ViewGroup.drawChild(ViewGroup.java:4333) at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4112) at android.view.View.draw(View.java:20214) at com.android.internal.policy.DecorView.draw(DecorView.java:780) at android.view.View.updateDisplayListIfDirty(View.java:19086) at android.view.ThreadedRenderer.updateViewTreeDisplayList(ThreadedRenderer.java:686) at android.view.ThreadedRenderer.updateRootDisplayList(ThreadedRenderer.java:692) at android.view.ThreadedRenderer.draw(ThreadedRenderer.java:801) at android.view.ViewRootImpl.draw(ViewRootImpl.java:3327) at android.view.ViewRootImpl.performDraw(ViewRootImpl.java:3124) at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2493) at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1468) at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:7208) at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1004) at android.view.Choreographer.doCallbacks(Choreographer.java:816) at android.view.Choreographer.doFrame(Choreographer.java:751) at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:990) at android.os.Handler.handleCallback(Handler.java:873) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loop(Looper.java:193) at android.app.ActivityThread.main(ActivityThread.java:6692) at java.lang.reflect.Method.invoke(Method.java) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

The below implementation of onMeasure is showing wrong height and width in <= 5.0 devices.

 @Override
    protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) {
        final int measuredWidth = resolveSize(loaderView.getDesiredWidth(), widthMeasureSpec);
        final int measuredHeight = resolveSize(loaderView.getDesiredHeight(), heightMeasureSpec);
        setMeasuredDimension(measuredWidth, measuredHeight);
    }