Refactor terraform. Automatically.

Change type information on variables from "map" to become "map(string)" on all equivalent collection types.

That is: map -> map(string) list -> list(string) ((?) set -> set(string) unsure of type set)

If the upgrade0.12 terraform cli command is used as reference, we can just assume all upgraded types will become X(string). As per https://github.com/hashicorp/terraform/blob/ffe5f7c4e60b8d759b1251ce81a2cb44c7190b8f/configs/configupgrade/upgrade_native.go#L115-L129

Changing type information referencing vpc_id = "${element(concat(aws_vpc.this.*.id, list("")), 0)}" to vpc_id = element(concat(aws_vpc.this.*.id, [""]), 0) -- note the change of list("") to [""]

Work in progress, using this issue as a placeholder.

• https://www.terraform.io/upgrade-guides/0-12.html

Note, many of these examples come from running terraform 0.12upgrade -yes -force on [email protected]

Things to be done:

• Be able to determine if in variable, output, locals, data, etc, separately from one another
  • partially, https://github.com/openrewrite/rewrite-terraform/issues/3
• https://github.com/openrewrite/rewrite-terraform/issues/12
  • Bonus, maybe: ChangeVariableName. The thing that's unnerving about this is that often a variable name change will involve destroying/recreating a resource of some sort. But, that's just off my memory. Not sure how true that is.
• https://github.com/openrewrite/rewrite-terraform/issues/5
• https://github.com/openrewrite/rewrite-terraform/issues/6
• Possibly just a bonus: ability to format using new 0.12 format rules
• https://github.com/openrewrite/rewrite-terraform/issues/7
• Handling of index addressing, e.g. vpc_id = "${aws_vpc.this.id}" becomes vpc_id = aws_vpc.this[0].id
• Possibly just a bonus: ingress = "${var.default_network_acl_ingress}" changing to a dynamic block, e.g. dynamic "ingress" {...
• https://github.com/openrewrite/rewrite-terraform/issues/4
• https://github.com/openrewrite/rewrite-terraform/issues/8
• Removal of unnecessary parenthesis, such as nat_gateway_ips = "${split(",", (var.reuse_nat_ips ? join(",", var.external_nat_ip_ids) : join(",", aws_eip.nat.*.id)))}" -> nat_gateway_ips = split(",",var.reuse_nat_ips ? join(",", var.external_nat_ip_ids) : join(",", aws_eip.nat.*.id))
• https://github.com/openrewrite/rewrite-terraform/issues/9

For helpful cross-reference, see:

• https://github.com/hashicorp/terraform/tree/v0.12.31/configs/configupgrade
• terraform vpc module upgrade PR: https://github.com/terraform-aws-modules/terraform-aws-vpc/pull/265/files

Bumps styfle/cancel-workflow-action from 0.8.0 to 0.9.1.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Scooting content along. See individual commit lines. Part of https://github.com/openrewrite/rewrite-terraform/issues/1

Includes content addressing

• https://github.com/openrewrite/rewrite-terraform/issues/4
• https://github.com/openrewrite/rewrite-terraform/issues/6
• https://github.com/openrewrite/rewrite-terraform/issues/7
• https://github.com/openrewrite/rewrite-terraform/issues/8

As per https://github.com/hashicorp/terraform/commit/26c1e40ad775297cc89b32794508f4d596615d5a

before:

locals {
  decimal_int          = 1
  decimal_float        = 1.5
  decimal_float_tricky = 0.1
  hex_int              = 0xff
  octal_int            = 0777
}

after:

locals {
  decimal_int          = 1
  decimal_float        = 1.5
  decimal_float_tricky = 0.1
  hex_int              = 255
  octal_int            = 511
}

Similar to FindResource, this requires FindVariable:

https://www.terraform.io/upgrade-guides/0-12.html#reserved-variable-names

In preparation for new features planned for future releases, Terraform 0.12 reserves some additional names that can no longer be used as input variable names for modules. These reserved names are:

count
depends_on
for_each
lifecycle
providers
source

When any of these names is used as the label of a variable block, Terraform will now generate the following error:

Error: Invalid variable name

on reserved-variable-names.tf line 2, in variable "count": 2: variable "count" {

The variable name "count" is reserved due to its special meaning inside module blocks.

Continuing to refine structure, etc.

Part of https://github.com/openrewrite/rewrite-terraform/issues/5 Part of https://github.com/openrewrite/rewrite-terraform/issues/1

Starts the ball rolling. Putting out scaffolding.

Part of https://github.com/openrewrite/rewrite-terraform/issues/1 Part of https://github.com/openrewrite/rewrite-terraform/issues/6

Replacement of ! for "false" with false, e.g. count = "${var.create_vpc && (var.enable_nat_gateway && ! var.reuse_nat_ips) ? local.nat_gateway_count : 0}" becomes count = var.create_vpc && var.enable_nat_gateway && false == var.reuse_nat_ips ? local.nat_gateway_count : 0

Changing referencing of functions on lookup, e.g. rule_number = "${lookup(var.public_inbound_acl_rules[count.index], "rule_number")}" becomes rule_number = var.public_inbound_acl_rules[count.index]["rule_number"]