This makes a few key changes:

• if a particular signal hasn't been received in at least 5 seconds, remove that signal from carState (and update flow)
• if we disconnect from a canserver (or mock server stopped), completely clear carState (and update flow)
• add logic to every individual view that if the signal it relies on is null, to hide the view (or set it to "")
  • typically this uses the elvis operator whenever we .let a value from carState to run logic only when the value is null
    • note the importance of avoiding viewModel.getValue() since that uses carState history which is not cleared
  • ...but every view is a bit different, sometimes instead of changing visibility, it was necessary to set the text to empty as other logic would just change the visibility back.

Test plan

• testing disconnection of panda server
  • using a panda server, abruptly disconnected the server during several different scenarios:
    • driving with telltales on, blindspot arcs on, etc
    • charging
    • doors open
  • ensured that each time, all elements were cleared out and returned to default view (not stuck in charging view for example)
• testing disconnection of mock server
  • from each cycle of the mock server, would stop the server and quickly launch dash
  • after the 2 second mock wait expired the signals would be cleared
  • ensured that all views cleared at this point
• testing the loss of individual signals
  • connected to vehicle and vehicle "on" (after pressing brake pedal)
  • all expected views visible: speedo, temps, torque, etc
  • turned "off" car by opening charge port door
  • all views which are not expected disappeared after a short wait: speedo, motor temps, brake temps, torque, PRND

Original signal used to switch to the charging view is PCS_hvChargeStatus which doesn't seem to switch away from 0 on non-SUC DC chargers (at least ones i tested). This PR changes that to BMS_chargeRequest, which seems to reliably go from 0 to 1 (with no intermediate or alternate values) when any kind of charging is initiated.

Alternative to this might be CP_chargeCablePresent if switching to charging view as soon as the connector is plugged in is more desireable. This might actually not be a bad idea, as seeing the green gauge on the screen will remind you the car is still plugged in when getting ready to leave.

This fixes issue #12

Allows for tapping the efficiency view to change between Last 5, 15, 30 miles, or 0 (instant). For KM the options are 10, 25, 50, and 0 km.

The instant efficiency is formatted to kWh with 2 decimal places as that value changes extremely rapidly and gets quite large. For historical efficiency it uses whole number Wh units to match the ICE.

The calculation is fairly close to the ICE, it updates faster so it never perfectly matches. The calculation discards any parked consumption/charging, and the history is retained even across app restarts or updates to newer versions.

Here's a video showing the 5 mile range, pending 15 and 30 mile ranges, and instant efficiency (including negative and infinity). Note there is flickering of the 5 mile range that is only an artifact of how I am playing back logged can data, and does not appear in-car. https://photos.app.goo.gl/qJzE7wvxaVwTkSWJA

To make room for the efficiency value to remain on-screen while stopped, the brake hold telltale was moved to replace the speedo when active, to match the behavior of US market cars. For simplicity other markets will share this same behavior in Candash.

Video of the updated brake hold: https://photos.app.goo.gl/29PefauszsgUs3WC9

Tested in-car with both miles and km units, instant efficiency, and each historical option for each unit. Ensured that history wasn't lost while restarting.

When the speed is 100 or greater (happens a bunch for us KM/h drivers) the speed overlaps the gauges on the right. This code will shift the speed label over.

CANServer supports mdns in version 2.1.0. When using your phone as a wifi hotspot you do not know the IP address that CANServer will be assigned but will be able to access the data via http://canserver.local

This addresses a couple of known issues, and makes our signals more robust to SNA values in general:

• max power will sometimes reflect ~1200kw (due to battAmps SNA)
• odometer will very briefly show over 4 million

it also allowed us to clean up some existing SNA code that was done specifically for gearSelector and fusedSpeedLimit.

If a decoded signal matches the sna value it will return null just as if the signal didn't exist, which will in turn blank out the relevant views for that signal.

Tested with mock server and real vehicle, unfortunately I can't reproduce the 1000+kw power bug on my system so will need to just hope and see if it fixes that bug for other users.

This provides an alternative to tapping into the trailer power wire for phone power to keep screen on while vehicle is on. It instead allows the screen to stay on as long as it's either charging or battery is above 20%. Then it blanks out the screen when the center display is off.

This only is useful on OLED devices, as you'd still see the screen backlight on LCD devices.

The option is disabled by default, can be enabled in the new settings page.

Tested using real can data from getting out of the vehicle and closing the door: https://photos.app.goo.gl/wULEzMUycnGvEmWPA In the video you'll see the following:

• driver gets out of vehicle and closes door, display blacks out with hint toast
• long pressed left side of display to open settings
• disabled the blackout option and returned to dash fragment, showing the screen is still on despite no driver presence
• re-enabled the blackout option and returned to dash to show the toast still pops up when returning to a dash that's already blacked out

Contains the following changes:

• constraints for the gauges have been a bit tidied up - the middle gauges now align to center of screen, and all the others align to those, gauge labels are top- and bottom- aligned to gauges, textview widths for the readouts now match the gauge widths etc.
• gauge labels have been changed so right side matches left (does not specify measured quantity, but the subsystem, e.g. brakes, motors, oil)
• this makes more room for the speedo so there's no more overlap at speeds >100 and esp. >200 km/h, which should also fix issue #10
• some of the labels have been realigned to grid a bit better, margins of some elements on the left now match the margins of elements on the right, turn signals are now aligned with the rest of the elements etc.

A ton of things, sort of hard to list them all (i probably should've split this up into multiple PRs, but it is what it is).

• general layout and constraint improvements, alignment nitpicks
• fix for speedo overlapping the readouts
• battery gauge improvements to mirror the main display and app better
• battery preheating indicator
• telltales for: lights, seatbelts status, brake hold, parking brake, TPMS
• odometer
• rudimentary battAmps filtering to avoid bizarre max discharge values
• fixed MockCANService race causing mistimed frames
• fixed MAX_FILTERS to correct value (43) in CANSignalHelper
• fixed formatting bug in Hex.java getString
• telltale colors abstracted into colors.xml for easier maintenance

I think that's more or less it. If anything's questionable or does not make sense let me know.

• changed proportions of the EU (round) speed limit sign - outline width, text size - to hopefully more closely match the main display icon
• experimentally resized and moved the round speed limit indicator centrally above the speedo
• added sign for no speed limit (Germany) if fused speed limit is reported as 155 km/h
• added PIN-to-drive prompt toast

Speed limit changes need testing, please don't merge yet.

This fixes the socket closed exception that occurs whenever switching between apps (candash in background) by not trying to send bye when already disconnected.

It also reduces the chance of the gauges flickering when coming across transient socket timeouts due to a weak signal or laggy canserver. It does this by shortening the timeout duration, but allowing for multiple timeouts (3) before it clears the carstate data.

Note that while the panda service will stay connected to the canserver for a short time while the app is in the background, the canserver would eventually disconnect candash because it won't see heartbeats while candash is in the background. If you rejoin candash after this, it reconnects very quickly without clearing data.

Test plan

• while candash is open, stop canserver abruptly, ensure the car data clears after 3 seconds (3 timeouts at 1 second each)
• while canserver is running, switch between candash and other apps, ensuring that the gauges don't blank out when resuming candash
  • tested within a single heartbeat duration, canserver stays connected
  • tested longer than a single heartbeat duration, canserver disconnects, but quickly reconnects once switching back to candash
• switched between panda service and mock service multiple times, ensuring no odd behavior.

Improvements:

• Simplified data transfer from CAN services to view model by removing intermediate live flow and collector.
• There is now a LiveData for each signal, and they are only updated when the signal value changes, resulting in far less data being sent
• DashViewModel provides helpers for observing changes for a single signal, some signals, or all signals
• Augmented CAN signals automatically calculate and add their values into the carState with real CAN signals, making things like power and smoothAmps accessible anywhere
• New unit converter class that automatically detects the preferred unit when converting signals
• Signal names and values split out from Constants to help identify what's what
• Code refactor, saving about 600 lines in DashFragment moving repeated code into functions and other structure improvements
• Code cleanup, removed long-unused code and comments (if we really need to get something back we have git)
• Linted code from hundreds of warnings to just dozens of warnings
• Bug fixes:
  • RWD/AWD detection fixed
  • Front torque gauge min not updating
  • Minor edge cases around changing to/from splitscreen while in different states such as doors open, charging, etc
  • Fixed light telltales for USDM vehicles, removed broken logic for EU market

This shouldn't functionally or visually change anything, if something is different or unexpected, let me know.

This does include some future code for a TACC icon, but is disabled in this PR, and will be enabled in a future PR once we have an icon to use for it.

Testing

This still needs more soak-testing in car, and by multiple people if possible. Leaving PR in draft until I'm more confident about it being stable.

Comparison

Before (dark theme) and after (light theme): https://photos.app.goo.gl/w3aGsRLAmYkPY7HS9

You can see that before frame times often went above the optimum time (green line), and many more renders were performed than necessary. After, the renders mostly stay below the optimum frame time, and less renders are performed (which is why the graph looks stuttery, that's a good thing)

It worked when AC charging:

But doesn't when DC charging:

Not sure which signal it uses to flip between the two, i'll dig around this weekend. Also not sure if it works when supercharging, nor whether this is maybe because i don't have chassis bus.

Running in Canada and using KM/h I see speeds 100+ fairly regularly.

The speed display ends up overlapping the gauges on the right in some circumstances (depending on the trailing digit).

I am going to work on a PR to deal with this.

This is a new bug. The most recent version has this issue. In addition, the font size in the same circular gauge is too large. I'm surprised that nobody previously reported this, so it could be an issue with my tablet.

Also would you consider adding a lateral acceleration gauge like some of the Tesla track mode models have? You could reuse the horsepower gauge code and display it above that gauge. It probably makes sense to convert the raw data to g units.

Thanks.

I'm using a custom mount with no power cord to try rthis out.

I would suggest to use android:keepScreenOn="true" on the https://github.com/osunick/candash/blob/main/android/app/src/main/res/layout/activity_fullscreen.xml

Since most people would not want their screen to turn off if the app is open.

Alternatively if you feel someone would not want this feature it could be a new pref in the settings allowing the end-user to eventually decide if they want or not the flag toggled.

2020 Model Y LR with FSD beta 10.8.1. CanDash works as expected except the steering wheel icon does not either turn blue or respond in any way with FSD engaged.