This is the PR for #1556 - see todos and comments

At the moment my implementation is stable and available in the beta.

At the moment I also added the uploads menu item here as a dummy since this PR will be merged after the reliable uploads has been released so you all can already see how it will look like.

Material Design spec for side nav drawer: http://www.google.com/design/spec/layout/structure.html#structure-side-nav

What has been done already:

• [x] integrate with toolbar and get navigation right
• [x] integrate new drawer implementation where menu items do have a checked state
• [x] FIXES #1210
• [x] FIXES #1383
• [x] Successor of #1537
• [x] integrate material style account switcher
• [x] implement colored circle/letter user icon with the right diameter in alignment to the oC server's implementation (this has already been implemented by @tobiasKaminsky an the account switcher branch)
• [x] remove old drawer implementation.
• [x] propagate account manager changes to the drawer including active account swapping
• [x] check for necessary fix for #1572 after #1493 has been merged to master
• [x] modify header design with larger user icon and menu item aligned switcher text and smaller overall drawer header height
• [x] implement account switching in header via avatar icons (always remember and show the last 3 accounts)
• [x] test what happens for really, really, really long account names with the menu items
• [X] heavy testing for all Activities to make sure they all call the toolbar setup methods after they set the view content <<<< I did a lot of this during the code review; @jesmrec , not sure if you have more to do here. <<<< Present in test plan

RELATED BUGS:

• [X] https://github.com/owncloud/android/issues/1657 [NOT REPRODUCIBLE]
• [X] Crash with no account: https://github.com/owncloud/android/pull/1559#issuecomment-251686981 [FIXED]
• [X] Duplicated account in navigation drawer: https://github.com/owncloud/android/pull/1559#issuecomment-251689167 [FIXED]
• [X] Inconsistent actions in options menu: https://github.com/owncloud/android/pull/1559#issuecomment-251692759 [OUT OF SCOPE]
• [X] Long names in manage accounts view https://github.com/owncloud/android/pull/1559#issuecomment-251729870 [FIXED]
• [x] Duplicated avatars in drawer https://github.com/owncloud/android/pull/1559#issuecomment-251933389 [FIXED]
• [X] Avatars are not updated https://github.com/owncloud/android/pull/1559#issuecomment-251937443 [FIXED]
• [X] Drawer under the toolbar in multiselection https://github.com/owncloud/android/pull/1559#issuecomment-252194713 [FIXED]
• [X] App closed if tap on back in login view https://github.com/owncloud/android/pull/1559#issuecomment-252231496 [FIXED]

POSSIBLE IMPROVEMENTS:

• [X] Confirmation dialog to remove accounts: https://github.com/owncloud/android/pull/1559#issuecomment-251691507 [FIXED]
• [X] Displaying account info in the list using the same way as the current account https://github.com/owncloud/android/pull/1559#issuecomment-251735447 [WONT FIX]
• [X] In drawer and manage accounts, either username or displayname, but both the same set up https://github.com/owncloud/android/pull/1559#issuecomment-251900859 [FIXED]
• [X] Deleted accounts "block" login account https://github.com/owncloud/android/pull/1559#issuecomment-251943423 [OUT OF SCOPE]
• [X] Current account is not needed in the account switcher https://github.com/owncloud/android/pull/1559#issuecomment-251936645 [FIXED]
• [X] Switch account by clicking on an account in "Manage Accounts" https://github.com/owncloud/android/pull/1559#issuecomment-252567447 [FIXED]

Hi everybody,

as per discussion, I created a separate branch and I also reimplemented the material changes from scratch not using the toolbar just the actionbar.

Things done:

• material design action bar with drawer
• blue login screen (reverted, for CI compliance)
• preference activity via delegation
• material icons (from the google material icon repo)
• Custom Progress Indication for action bar has been added since AppCompat doesn't provide this anymore
• travis build fixed with new exploded aar AppCompat version and modified setup_env files to utilize Android-22 for compilation of the AppCompat instead of Android-16
• Fix for #710

Open Issue:

• spinner coloring for the pull to refresh is light grey (okay for the moment due to new progress indicator), can imho be ignored for now du to the Custom Progress Indicator --> DONE

@davivel @tobiasKaminsky @jancborchardt @Stoyicker

Based on #346, this summarizes all ideas to get a clean idea how to implement this long awaiting feature. I will update the description when there is a new idea or something is unclear, so that this is up to date. First the way to do is shown, then all possible problems or scenarios are described...

Desired behaviour: When uploading a file through owncloud app the file get uploaded to the owncloud server and remains on the place on the device. In the database of the app an entry is created which stores the local path. When opening/downloading a file the app first tries to open and verify the file in the local path that is stored in the database. If the file is there and up-to-date it will be shown. If it is not there, the file will be downloaded and be stored in the local owncloud folder structure.

TODO The user needs to be informed that the file is shared with owncloud. This means that the original file keeps untouched, even if the remote file changes.

File gets deleted on server: The file also get deleted from the database and from the local owncloud folder.

File gets deleted only on device (via ownCloud App): This option deletes the file from local owncloud folder.

File gets changed on server: When opening the file with owncloud app it is determined if the file is up to date. Otherwise it will be downloaded and be added to local owncloud folder.

File gets changed on device: As now the file needs to be selected in owncloud app and choose "refresh file". This will upload the file change to the server --> nothing special here.

File is "kept-to-sync" on one account: File is kept in local owncloud path on device, but gets updated as soon as the server file has been changed.

File is "kept-to-sync" on multiple accounts: If there is a change on the server the local owncloud file will be updated. But none of the other files will be modified. Example: There are three distinct files to work with: $account1/test.txt, $account2/test.txt, and /data/test.txt. So if $account1/test.txt is updated on the server, then the update should be downloaded and displayed if the user opens $acount1/test.txt. However, if the user locally modifies /data/test.txt, neither the account1 nor account2 copy should be updated.

I hope I have summarized this correctly. If not, or something is unclear, please feel free to comment. Please also comment if this should be done this way.

With the Material Design almost in place, we should really have an intro screen which introduces the features of our OwnCloud App something what dropbox or box or even Google Drive does..

@AndyScherzinger what are your thoughts??

TASKS

• [X] [GIT] Rebase legacy PR
• [x] [DEV] Choose features to include and the order in which they should appear.
• [x] [DESIGN] Design some mockups.
• [x] [DEV] Create new resources for the steps.
• [x] [DEV] Check old code and apply the changes needed.
• [x] [DEV] Include flag to enable or disable it.
• [x] [DEV] Code review
• [X] [QA] Design test plan @jesmrec
• [X] [QA] Execute test plan @jesmrec
• [x] [GIT] Merge branch

As discussed in #899

TASKS:

• [x] Code review @jabarros
• [x] Changes after CR @jabarros
• [X] [QA] Create 'multiSelect' branch in QA Repo @jesmrec
• [X] [QA] Merge 'multiSelect' branch in QA Repo @jesmrec
• [X] [QA] Create test plan @jesmrec
• [X] [QA] Validate test plan @jesmrec @mcastroSG

QA:

• [x] Check updated icons https://github.com/owncloud/android/pull/1424

Open bugs/improvements:

• [X] https://github.com/owncloud/android/issues/1347 [FIXED]
• [X] https://github.com/owncloud/android/issues/1411 [FIXED] ~~#1714~~ #1715
• [X] https://github.com/owncloud/android/issues/1412 [FIXED]
• [X] https://github.com/owncloud/android/issues/1605 [FIXED]
• [X] CRASH: https://github.com/owncloud/android/pull/1176#issuecomment-225573680 [FIXED]
• [X] CRASH:https://github.com/owncloud/android/pull/1176#issuecomment-225602576 [FIXED]
• [x] "Move" option incorrect in multiselection https://github.com/owncloud/android/pull/1176#issuecomment-228726233 [FIXED]
• [X] Multiselection of av. offline https://github.com/owncloud/android/pull/1176#issuecomment-228735066 --- moved to new issue #1726 [FIXED] @jabarros
• [X] Select all option https://github.com/owncloud/android/pull/1176#issuecomment-229010605 --- moved to new issue #1727
• [X] Folder moved into itself https://github.com/owncloud/android/pull/1176#issuecomment-229029762 @davivel @jabarros [FIXED]
• [X] download file icon is the same as available offline https://github.com/owncloud/android/pull/1176#issuecomment-229891594 @davivel [FIXED]
• [X] av. offline icon https://github.com/owncloud/android/pull/1176#issuecomment-230223452 @davivel [FIXED]
• [X] copy/move target folders multiselection https://github.com/owncloud/android/pull/1176#issuecomment-231035343 @davivel [FIXED]
• [X] Lack of 'three-dots' menu in tablets: https://github.com/owncloud/android/pull/1176#issuecomment-231965406 [WONT] @davivel --> see #1738
• [X] 'Wait a moment' dialog has been removed without protecting files/folder being updated - should be recovered https://github.com/owncloud/android/pull/1176#issuecomment-230287774 @davivel [FIXED]

It would be great if there could be a choice of various "views" for images/image folders.

A flickr style view for example, showing thumbnails of images.

@owncloud/android-developers

Time has come.

From my POV, this is finally ready to be tested by QA (cc @jesmrec).

Many hands contributed here, starting with the awesome effort of @LukeOwncloud. Sounds wise summoning many eyes to review it. So, any comment about the code will be welcome.

Though many things have been rewritten and considerably cleaned-up, sure you will still find many points that could (and should) be refactored. I can't promise that all of them may be attended in this PR, since we really, really, need to release this with next version 1.9.2, that should be very near in time to the release of OC 9. Evolution of testing is the leading criteria right now.

This means: if we think we can refactor something in a safe manner without introducing an important risk for QA, we will do. If bugs appear and the code to fix is also subject of comments in the code review, we will apply the comments.

But if change requests are big enough to require QA starts the testing all over again, we will have to wait for a better chance.

This one should not be too far in time. This PR lets aside an important topic that was originally addressed by @LukeOwncloud , the improvement of automatic retries. Right now instant uploads are retried when Wifi connection is established, in a similar way to the operation of the currently released version 1.9.1 [1]. But other convenient improvements will be addressed specifically in the short term [2], not in this PR. And that should be a good moment to improve the code of uploads further.

Come on Barbie, let's go party!

[1] You may notice some light improvements, but that's a side effect of the many changes done; was easier let it that way that adding artificial limits. Have fun finding them :)

[2] If you don't want to wait and prefer to implement them, go for it. Just mention me to let me know, and I'll try to help.

BUGS FOUND AND ENHANCEMENT:

• [x] Failed uploads can not be retried in another account #1497
• [x] Failed uploads are not retried by the button #1498
• [x] Deleting an account does not clear the current uploads #1499
• [x] Killing the app leaves uploads in an inconsistent state #1500
• [x] Wording issues in uploads view #1501
• [x] Manual retries are "delayed #1502
• [x] Uploads in SAML requests authentication twice #1503
• [x] Current upload should be in the top of the uploads view #1511
• [x] Only current upload in progress naming as "Uploading" #1520
• [x] Retry failed uploads start uploading by the bottom #1521
• [x] Credentials requested on each failed upload #1522
• [x] Uploaded files are possible to uploaded it again #1523
• [x] Title on top bar in upload view is shown sometimes owncloud instead of Uploads #1524
• [x] Failed Uploads set as wrong status "Waiting for wifi connectivity" #1525
• [x] Show account info also while the file is uploading or waiting to upload #1526
• [x] Title on top bar in upload view is shown the name of the failed upload #1530
• [x] Some Instant uploads naming as "Unknown error" #1531
• [x] Uploads with status "Waiting wifi connectivity" are not retried #1532
• [x] Clear all uplodas does not cancel all the current uploads #1533
• [x] Current upload can't be cancelled (Android 4.1.2) #1535
• [x] Progress bar not updated in uploads view when the upload is retried manually (Android 4.1.2) #1536
• [x] Upload the same file to different folder fails #1549
• [x] Deleting a file while uploading results in "Connection error" message instead of "file deleted locally" #1528
• [x] Background color should be white everywhere #1426
• [x] Thumbnails not shown in UPLOADED section #1517
• [x] If the same file is uploaded twice, both uploads are removed from list #1553
• [x] Yellow arrow when the file has a duplicated name #1554 [OUT OF SCOPE]
• [x] If wifi is lost, only one upload is move to failed #1569
• [x] Username in drawer not refreshed when account is removed from uploads view #1572
• [x] When a lot of files is sent to uploads view, progress bar is not correctly managed #1573
• [x] Upload path does not appear in "Uploaded" #1576

This PR is for discussion and experimentally test driving a FAB implementation.

Nothing to see yet but I wanted to open a PR in order to check for build compliance and discuss the progress and changes/adaption of any feedback. Incorporating the discussion on #983

The branch is based on latest master as in release 1.9.1

Actual behaviour

With Instant Upload turned on, no pictures or videos are automatically uploaded, with or without the "wifi only" toggle on. After reading the related issues, it seems like generally Instant Upload works on Android 7, but some specific phones are having issues.

Expected behaviour

Pictures and videos should automatically upload.

Steps to reproduce

1. Enable instant upload in the settings. Set the appropriate folder for pictures (tried both internal and external SD card).
2. Take a picture.
3. The picture is not uploaded - and does not show in the Uploads section.

Can this problem be reproduced with the official owncloud server? (url: https://demo.owncloud.org, user: test, password: test) Yes

Environment data

Android version: 7

Device model: LG v20

Stock or customized system: Stock

ownCloud app version: 2.1.2 (built from master branch on Oct 22).

ownCloud server version: 8.1

Logs

Web server error log

No relevant logs found.

ownCloud log (data/owncloud.log)

No logs found.

Hi,

Is it possible for the video files [mp4 h264] which are stored on owncloud, to be streamed directly, instead of them being downloaded and than played.

Using Android 4.4.4 Nexus 5 android app 1.5.8

PENDING TASKS:

• [X] [GIT] Create branch in Android repo
• [X] Use ExoPlayer library instead of VideoView because it was not possible to set headers for the authentication in < Lollipop devices.
• [X] Create custom http data source for setting authentication headers (ExoPlayer doesn't implement it).
• [X] Add full screen mode manually (ExoPlayer doesn't implement it).

• Important: This full screen mode is different to the one we previously had in the app. To go into full screen mode there is a new button in the playback controls and to exit the full screen mode, there is other button in the same place when full screen mode is enabled.

• [X] Handle full screen modes. Two full screen modes to implement depending on the Android versions:

• < 4.4 KitKat: Full screen with a limitation, the least user interaction will cause navigation controls to reappear immediately. Once the navigation controls have reappeared, they are not hidden again, even if the user clicks in the view.
• >= 4.4 KitKat: App goes truly full screen using immersive mode, system bars are automatically hidden. User swipes to display the system bars.

• [X] Options in menu. Remove options not necessary to stream
• [X] If the file is being downloaded you can not stream it, and if the user taps over the file a progress bar will be shown
• [X] If new version is available it should works as always. Update the current file while play it.
• [X] Detect SSL certificate to choose between download/stream. In this case, when the certificate is untrusted, an specific error message is shown to the user and after that, the streaming view is closed and the download starts automatically.
• [X] Improve full screen button behaviour, avoiding show it till the player is ready to reproduce the video
• [X] Hide unnecessary options to stream in tablets [FIXED] @davigonz , @jesmrec
• [X] Video playback state and autoplay are missed while rotating the screen in preview mode, not in full screen mode [FIXED] @davigonz @jesmrec
• [X] Video playback state and autoplay are missed while changing from preview mode to full screen mode and vice versa [FIXED] @davigonz @jesmrec
• [X] [QA] Design test plan @jesmrec
• [x] [QA] Validate test plan [WIP] @jesmrec
• [x] [GIT] Merge branch in Android repo

BUGS & IMPROVEMENTS

• [X] Crash when session expires https://github.com/owncloud/android/issues/592#issuecomment-282977504 [FIXED] @davigonz , @jesmrec
• [X] Root folder when video can not be streamed https://github.com/owncloud/android/issues/592#issuecomment-282978338 [FIXED] @davigonz , @jesmrec
• [X] Error message with no connection https://github.com/owncloud/android/issues/592#issuecomment-283001683 Remains in black screen ¿regression?. Check https://github.com/owncloud/android/issues/592#issuecomment-283408703 [FIXED] @davigonz , @jesmrec
• [X] Resume video after sharing https://github.com/owncloud/android/issues/592#issuecomment-283013464 @davigonz , @jesmrec [FIXED]
• [X] Download and Streaming at the same time https://github.com/owncloud/android/issues/592#issuecomment-283018269 [FIXED] @davigonz , @jesmrec
• [X] Options missed https://github.com/owncloud/android/issues/592#issuecomment-283025413 [FIXED] @davigonz , @jesmrec
• [X] Unsupported video files make the app crash https://github.com/owncloud/android/issues/592#issuecomment-283028375 [FIXED] @davigonz , @jesmrec
• [X] Error message in slow connection https://github.com/owncloud/android/issues/592#issuecomment-283029422 [FIXED] @davigonz , @jesmrec
• [X] Removed video makes crash https://github.com/owncloud/android/issues/592#issuecomment-283035219 [FIXED] @davigonz , @jesmrec
• [X] Videos in flv shows a different error message https://github.com/owncloud/android/issues/592#issuecomment-283411879 [FIXED] @davigonz , @jesmrec
• [X] Error when session expires in full screen https://github.com/owncloud/android/issues/592#issuecomment-283417772 [FIXED] @davigonz , @jesmrec
• [X] Error message after remove a video in server and switch to full screen mode https://github.com/owncloud/android/issues/592#issuecomment-283581582 [FIXED] @davigonz , @jesmrec
• [X] Crash in devices with 4.0.0 and 4.0.3 Ice Cream Sandwich versions while starting the video previewing or streaming https://github.com/owncloud/android/issues/592#issuecomment-286067156 [FIXED] @davigonz , @jesmrec
• [X] https://github.com/owncloud/android/issues/859 [FIXED]
• [X] Different error messages for unsupported video files https://github.com/owncloud/android/issues/592#issuecomment-287054019 [WON'T FIX]
• [X] Expiration message is "not supported format" https://github.com/owncloud/android/issues/592#issuecomment-287055099 [WON`T FIX]
• [X] Should not-playable videos be downloaded always? https://github.com/owncloud/android/issues/592#issuecomment-287058618 [FIXED] @davigonz @jesmrec
• [X] Cancel button does not work https://github.com/owncloud/android/issues/592#issuecomment-287064011 [FIXED] @davigonz @jesmrec
• [X] Crash after downloading in 4.0.3 https://github.com/owncloud/android/issues/592#issuecomment-287303804 [FIXED] @davigonz @jesmrec
• [X] Crash in 4.0.3 while if orientation changes during download https://github.com/owncloud/android/issues/592#issuecomment-287331801 [FIXED] @davigonz @jesmrec
• [X] Video is streamed in av. offline https://github.com/owncloud/android/issues/592#issuecomment-287718525[FIXED] @davigonz @jesmrec
• [X] Error message in 302 redirections untrusted certificate https://github.com/owncloud/android/issues/592#issuecomment-287745048 [FIXED]
• [X] New version is downloaded and streamed https://github.com/owncloud/android/issues/592#issuecomment-287749600 [WONT_FIX]
• [X] Bad error message when forwarding video in expirated SAML session https://github.com/owncloud/android/issues/592#issuecomment-288007065 [READY_TO_TEST]
• [X] Download error in notification bar when session expires https://github.com/owncloud/android/issues/592#issuecomment-288007737

Is it possible to include a function to sync the calendar, contacts and possibly the Notes? Else i have to use (paid) apps like CardDAV-Sync free beta and CalDAV-Sync beta.

Bumps ioInsertKoin from 3.2.0 to 3.3.2. Updates koin-core from 3.2.0 to 3.3.2

Updates koin-androidx-workmanager from 3.2.0 to 3.3.2

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Bumps orgJetbrainsKotlin from 1.7.20 to 1.8.0. Updates kotlin-gradle-plugin from 1.7.20 to 1.8.0

Updates kotlin-stdlib-jdk8 from 1.7.20 to 1.8.0

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Actual behaviour

• i have activated the Automatic Upload of my Photos and Videos. I choosed the Directory on my Android Phone and Destination Directory. It works, but i have always duplicates in my owncloud folder.

Expected behaviour

• Skipped existing and successfully pics and videos.

Can this problem be reproduced with the official owncloud server? No

Environment data

Android version: OxygenOS 13.0|Android 13

Device model: Oneplus 8 Pro

Stock or customized system: Stock

ownCloud app version: 3.0.1

ownCloud server version: 10.0.10.1 running on Qnap

Logs

Web server error log

Insert your webserver log here

ownCloud log (data/owncloud.log)

Insert your ownCloud log here

TASKS:

• [ ] Approve and merge changes in ownBrander
  • [ ] Version number
  • [ ] Webfinger https://github.com/owncloud/ownbrander/pull/1048
• [ ] [OPS] Block oB button
• [ ] Merge changes in building scripts (if needed)
• [ ] [GIT] Create and sign tag oc-android-3.x_oem in HEAD commit of release_3.0_oem branch or 3.0 commit
• [ ] [OPS] Deploy oB
• [ ] [QA] Generate final APKs files from signed commit in builder machine and perform some basic operations
• [ ] [QA] Check that bundle is correctly generated and apk family could be installed in device from bundle (depending on if there's new changes or not), in owncloud/android
• [ ] [OPS] Enable button

BUGS & IMPROVEMENTS

From https://github.com/owncloud/ocis/issues/4111

Steps to reproduce

1. in oCIS, create a public link over a folder with default permissions
2. Edit the link, setting permissions to Upload only (file drop)
3. Save it
4. Open the link again

Actual behaviour

Permission is Download/View/Upload . This is because sending together publicUpload and permissions in the request leads to some confusion. PUT returns 15 instead of 4

Expected behaviour

Correct level of permissions. By removing publicUploads parameter from the request payload, should be enough (tests will confirm)

Samsung A51, Android12