I applied your library on listview item, whenever I scroll every listview item I touch while scrolling will get the ripple is applied to it.

Thanks in advance.

Would you consider prefixing custom attributes so they don't conflict with other dependencies? I'm noticing srcCompat is being used in this library and a few others without any prefixing and could cause attribute already defined errors.

I use RippleDrawable in ListView Adapter's getView method, when I pressed and hold, it work normally, but if I pressed and hold and then scroll, onFingerUp() do not get fired.

If I set up background like

<shape
    xmlns:android="http://schemas.android.com/apk/res/android"
    android:shape="oval">
    <solid android:color="@color/wl_blue"/>
</shape>

I see "square" effect

When following instructions, when I include the library and use in /drawable I still get the error message saying that it only works on v21+, so it gets the old one.

Hi im really a noob. Could somebody explain me how to add this library to my project without gradle? Started with Android Studio and never needed exporting Git dependencies so far.

Choice 1: Reverting a merge can be accomplished using:

http://git-scm.com/blog/2010/03/02/undoing-merges.html

Choice 2: use git reset "HEAD^" on master till you reaches the stable commit, clean up, and push -f

Choice 3:

• checkout to the last stable commit, say, git check COMMIT_ID
• remove the master branch by git brand -d master
• create a master branch base on the commit, say, git checkout -b master
• push to remote: git push -u origin/master -f

All these method requires to rewrite the master header(except Choice 1 which produces a reverse commit). I haven't tried in github, but these methods work on some other remote repos. I assume they should be the same.

Good Luck.

Have someone experience in replacing Resources in whole application, i need to intercept getDrawable method everywhere

Testing on Genymotion, Android 4.1.1

i need some ideas how to work around

1. Approach to wrap context when attachBaseContext method called, failed. When inflating views it doesn't works :(
2. I found really strange behavior that the original(android) views and custom views are getting different types of Context. Cause i made efforts to set background via XML on ImageButton and get Exception, but when i create custom view extended from ImageButton it worked update on approach 2 hmm, looks like if i define background as an attribute it falls, if do it by code it works

i found what is going on after all, the views calls TypedArray#getDrawable method

    public Drawable getDrawable(int index) {
        if (mRecycled) {
            throw new RuntimeException("Cannot make calls to a recycled instance!");
        }

        final TypedValue value = mValue;
        if (getValueAt(index*AssetManager.STYLE_NUM_ENTRIES, value)) {
            if (value.type == TypedValue.TYPE_ATTRIBUTE) {
                throw new RuntimeException("Failed to resolve attribute at index " + index);
            }
            return mResources.loadDrawable(value, value.resourceId, mTheme);
        }
        return null;
    }

Now i need to think how to replace loadDrawable method :disappointed:

New plan, going to replace LayoutInflater with custom one and create custom attributes like Calligraphy did

Error occurs when I try to use your library on CardView inside RecyclerView on devices older then L, but on Lollipop devices everything is fine. Throws java.lang.ClassCastException: dreamers.graphics.RippleDrawable cannot be cast to android.support.v7.widget.RoundRectDrawableWithShadow. What is wrong? Thanks in advance.

Assuming the last intended-for-master commit was 3512988, this reverts the intervening commits.

Let me know if I picked the wrong commit! Or feel free to tackle that yourself: I just used git checkout 3512988 . and then add / remove files as necessary to get git diff 3512988 to be empty. It's a bit coarse perhaps, but it gets the job done, and works no matter what the history looks like.

If you press an item of half-empty scrollable container (which is obliviously not scrollable now) and move your finger away out of the item's bounds and then release... view is being clicked. This is probably not perfect solution, but it solves the issue.

Hello, The RippleDrawable of the Android 9.0 Pie, is very better than the Lollipop one. Please update the codes to backport Android 9.0 ripples to the older version (back to API 14 or 17).

Since there hasn't been much activity on this repository, I created a fork and cleaned up the code. My library can be found here, I hope to keep it up-to-date and maintained: https://github.com/addisonElliott/RippleDrawable

Check out the README for instructions on installing.

in LayerDrawable.class privated method updateStateFromTypedArray() state.mPaddingMode=a.getInteger() . Can't convert to Integer TYPE= 0x3 . Samsung,android 4.4.2, API 19(KITKAT)

On KitKat the ripple is rectangular and only extends inside the view's margin unlike on Lollipop which can extend into a full circle outside the available margins.

RippleDrawable#getDirtyBounds() calls super. It is API >= 21 method but is missing from LollipopDrawable. This exception only happens on pre-lollipop Androids.