See #488

~We need to wait bintray support gradle 4.6 or release this alpha version manually ✋~

TODO

• [x] Support androidx
• [x] Drop support v4
• [x] Handle the problem with bintray-release

NOT TODO for this PR

• Drop native fragment support

ref: https://github.com/hotchemi/PermissionsDispatcher/issues/187

This is definitely unexpected, but some devices like from Xiaomi need different check flow to get the state of permission. Currently we provide PermisisonUtils in library module, but I'm thinking to provide the following interface to allow users to put in their original logic.

@RuntimePermission(checker = XiaomiChecker.class) // default value is PermisisonUtils.class
class Some {
}

@aurae @shiraji What do you think?

@a1018875550 Can you solve the problem with above interface?

When I include PermissionsDispatcher code, my project fails to clean build with following error message:

Error:Execution failed for task ':sample:clean'.

Unable to delete file: C:\PermissionsDispatcher-master\PermissionsDispatcher-master\sample\build\intermediates\exploded-aar\PermissionsDispatcher-master\library\unspecified\jars\lint.jar

If I remove this PermissionDispatcher code including from build.gradle file then everything working fine.

The phone is htc m8sw,os version is android 6.0.1.I use your library，but both OnNeverAskAgain and OnShowRationale are never called. Library version is 2.1.0.Help me.

As you know, Xiaomi devices have their own system of permissions. I'm testing my application on the device xiaomi redmi 3, api 22, android 5.1.1. I want to check if there is permission to access the camera and audio. boolean b = hasSelfPermissionForXiaomi(getActivity(),"android.permission.CAMERA");} `

private boolean hasSelfPermissionForXiaomi(Context context,String permission){
String permissionTop = AppOpsManagerCompat.permissionToOp(permission);
if(permissionTop == null){
    // not dangerous
    return true;
}
int noteOp = AppOpsManagerCompat.noteOp(context,permissionTop, Process.myUid(),context.getPackageName());
return noteOp == AppOpsManagerCompat.MODE_ALLOWED && checkSelfPermission(context,permission) == PackageManager.PERMISSION_GRANTED;}`

b = true, although this is not true.

After enabling the Jack, Im getting permissions.dispatcher.processor.exception.SupportV13MissingException: PermissionsDispatcher for annotated class 'MyFragment' can't be generated, because the support-v13 dependency is missing on your project

The v13 dependency is in place, it works fine if I switch back to apt plugin.

This enhancement is derived from #56, in which the OP asked for a more convenient way to use PermissionDispatcher's delegate pattern. In my opinion, it would make sense to embed custom lint checks that prevent users from directly invoking methods annotated with @NeedsPermission. Furthermore, another check would raise a warning (preferably an error) if the call to the delegate object's onRequestPermissionsResult() method is omitted in the respective Activity / Fragment method.

@NeedsPermission(Manifest.permission.CAMERA)
void useCamera() {
}

// Somewhere else...
void onCameraButtonClicked() {
    this.useCamera();    // This line would raise a lint error ("Trying to access permission-protected method directly", for instance)
}

Futher reading (tools.android.com)

see #59

TODO

• [x] Add a lint that checks calling @NeedsPermission method, directly
• [x] Add a gradle task that injects lint.jar to PermissionsDispatcher

NOT GOING TO DO

Because they make this pull request huge and there are no test cases, I won't do followings for this pull request.

• Add test cases
• Add a lint that checks implementing onRequestPermissionsResult() except WRITE_SETTINGS or SYSTEM_ALERT_WINDOW
• Add test cases for implementing onRequestPermissionsResult() except WRITE_SETTINGS or SYSTEM_ALERT_WINDOW
• Add a lint that checks implementing onRequestPermissionsResult() except WRITE_SETTINGS or SYSTEM_ALERT_WINDOW in Activity (not Fragment since user may skip it in case it handles in another Fragment.)
• Add test cases for implementing onActivityResult() if it's asking WRITE_SETTINGS or SYSTEM_ALERT_WINDOW in Activity

Overview

I've two permissions in my fragment (camera and storage) this is my code for them:

private fun checkCameraPermission() {
        constructPermissionsRequest(
                Manifest.permission.CAMERA,
                onShowRationale = { request ->
                    showPermissionRationaleDialog(
                            Manifest.permission.CAMERA,
                            onAccept = { request.proceed() },
                            onDeny = { navigateHome() }
                    )
                },
                onPermissionDenied = {
                    navigateHome()
                },
                onNeverAskAgain = {
                    showPermissionNeverAskAgainDialog(
                            Manifest.permission.CAMERA,
                            onDeny = { navigateHome() }
                    )
                }
        ) {
            showCamera()
        }.launch()
    }

    private fun checkStoragePermission() {
        constructPermissionsRequest(
                Manifest.permission.WRITE_EXTERNAL_STORAGE,
                onShowRationale = { request ->
                    showPermissionRationaleDialog(
                        Manifest.permission.WRITE_EXTERNAL_STORAGE,
                        onAccept = { request.proceed() }
                    )
                },
                onNeverAskAgain = {
                    showPermissionNeverAskAgainDialog(Manifest.permission.WRITE_EXTERNAL_STORAGE)
                }
        ) {
            saveFile()
        }.launch()
    }

I'm calling checkCameraPermission() on my fragment's onStart() function. but there is a save button for calling checkStoragePermission(). Everything works great. until when I go to setting and manually disable storage permission from there. After returning to the fragment when I press the save button, Rationale shows up but when I accept button the system permission dialog doesn't show up. (I set a breakpoint and I saw that request.proceed() called. but It doesn't jump to the requiresPermission method.) The Strange part is that If I disable checkCameraPermission() from onStart() It will work.

Expected

System dialog shows up event after manually disabling permission from setting

Actual

System dialog doesn't show up, after manually disable permission from setting (when there is two permission checks on the fragment)

Environment

• Which library version are you using? ktx 1.0.1
• On which devices do you observe the issue? all devices

Overview

• I'm working on a android project with Build Tool Version 25.0.2 and added dependency for Permission Dispatcher. When i am building the project, library is not generating any Permission Dispatcher classes at all corresponding to any Activity or Fragments which has annotation @RuntimePermissions. It is working fine if Build tool version downgrades to <25.

After https://github.com/hotchemi/PermissionsDispatcher/pull/227 was merged and I bumped the version in app, it looks like there is a misfiring lint check.

This is the check — NeedOnRequestPermissionsResult: Call the "onRequestPermissionsResult" method of the generated PermissionsDispatcher class in the respective method of your Activity or Fragment

And here is code that it is triggering on:

    @Override
    public void onRequestPermissionsResult(int requestCode, String[] permissions,
            int[] grantResults) {
        super.onRequestPermissionsResult(requestCode, permissions, grantResults);
        FooBarFragmentPermissionsDispatcher
                .onRequestPermissionsResult(this, requestCode, grantResults);
    }

So the call to the PermissionsDispatcher is actually happening but the lint check does not think it is.

cc @eyedol @hotchemi @felipecsl

Overview

When we are asking for permission on Fragment launch inside onViewCreated() method. Both @OnNeverAskAgain and @NeedsPermissionare getting called immediately. and if we are asking permission on some button click then it is working fine.

Expected

• It should not call @OnNeverAskAgain without any action along with @NeedsPermission

Actual

• On fragment launch, both @OnNeverAskAgain and @NeedsPermissionare getting called immediately.

Environment

• Which library version are you using? Current Version implementation 'com.github.permissions-dispatcher:permissionsdispatcher:4.9.2' kapt 'com.github.permissions-dispatcher:permissionsdispatcher-processor:4.9.2'

• On which devices do you observe the issue? One Plus 7 Android 11 , Samsung M30 and other

https://user-images.githubusercontent.com/25843884/190325927-54570126-6f24-4305-9c94-c59f034ca1e9.mov

We are trying to upgrade project code to Kotlin 1.7 however PermissionsDispatcher blocks us as it only supports Kotlin 1.5. Is there any plan to support Kotlin 1.7? Below is the error:

Caused by: java.lang.IllegalArgumentException: Modifiers [PRIVATE] are not allowed on Kotlin parameters. Allowed modifiers: [VARARG, NOINLINE, CROSSINLINE]
	at com.squareup.kotlinpoet.ParameterSpec.<init>(ParameterSpec.kt:41)
	at com.squareup.kotlinpoet.ParameterSpec.<init>(ParameterSpec.kt:29)
	at com.squareup.kotlinpoet.ParameterSpec$Builder.build(ParameterSpec.kt:157)
	at com.squareup.kotlinpoet.FunSpec$Builder.addParameter(FunSpec.kt:500)
	at permissions.dispatcher.processor.impl.kotlin.KotlinBaseProcessorUnit.createPermissionRequestClass(KotlinBaseProcessorUnit.kt:452)
	at permissions.dispatcher.processor.impl.kotlin.KotlinBaseProcessorUnit.createPermissionRequestClasses(KotlinBaseProcessorUnit.kt:415)
	at permissions.dispatcher.processor.impl.kotlin.KotlinBaseProcessorUnit.createFile(KotlinBaseProcessorUnit.kt:43)
	at permissions.dispatcher.processor.impl.kotlin.KotlinBaseProcessorUnit.createFile(KotlinBaseProcessorUnit.kt:17)
	at permissions.dispatcher.processor.PermissionsProcessor.processKotlin(PermissionsProcessor.kt:68)
	at permissions.dispatcher.processor.PermissionsProcessor.process(PermissionsProcessor.kt:58)
	at org.jetbrains.kotlin.kapt3.base.incremental.IncrementalProcessor.process(incrementalProcessors.kt:90)
	at org.jetbrains.kotlin.kapt3.base.ProcessorWrapper.process(annotationProcessing.kt:197)
	at jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment.callProcessor(JavacProcessingEnvironment.java:980)

Keep a strong reference to onNeverAskAgain to avoid the WeakRefence to it stored on PermissionRequestViewModel to become null when user denies permission multiple times. This should resolve #767 .

Overview

onNeverAskAgain callback is not called when "Don't ask again" is selected.

Expected

onNeverAskAgain callback is called, so I can show the appropriate UI.

Actual

onNeverAskAgain callback is not called.

Environment

• Running ktx-sample on API 29 and API 30, using ktx v1.1.3

Investigation

After debugging it, I can see that onNeverAskAgain: WeakReference<Fun>? is null in PermissionRequestViewModel.invoke(). After reading through the closed issues, I came across https://github.com/permissions-dispatcher/PermissionsDispatcher/issues/735. Wondering if the weakreference could be the issue? If I downgrade the ktx library to 1.0.4, onNeverAskAgain is successfully called.

Reproducible steps

https://user-images.githubusercontent.com/35034828/158357946-129980bf-6547-4228-82a4-a03399f88269.mp4

Resolves https://github.com/permissions-dispatcher/PermissionsDispatcher/issues/765

Overview

• Changed to use Fragment as a LifecycleOwner when PermissionRequester is constructed by Fragment
• For Activity, it changes nothing (uses Activity as a LifecycleOwner just like before)

GIFs

Behaviors of sample app before | after -- | -- |