android:maxLines Makes the TextView be at most this many lines tall. When used on an editable text, the inputType attribute's value must be combined with the textMultiLine flag for the maxLines attribute to apply.

XML attribute: https://developer.android.com/reference/android/widget/TextView?hl=en#attr_android:maxLines

Jetpack Compose:

Text(
   ...
   maxLines = Int = Int.MAX_VALUE
   ...
)

We are parsing TextView here: https://github.com/pocmo/recompose/blob/main/recompose-parser/src/main/kotlin/recompose/parser/xml/view/TextView.kt

And create a TextViewNode from it: https://github.com/pocmo/recompose/blob/main/recompose-ast/src/main/kotlin/recompose/ast/view/TextViewNode.kt

And we turn the node into Kotlin code here: https://github.com/pocmo/recompose/blob/main/recompose-composer/src/main/kotlin/recompose/composer/visitor/ComposingVisitor.kt#L82-L94

To solve this issue:

• Parse the attribute and add the value to TextViewNode. Probably a nullable Int? is needed.
• Add it to the list of parameters in ComposingVisitor.
• Add a test case to ParserTest and ComposerTest.

Using ConstraintLayout you'd often set android:layout_width or android:layout_height of a View to 0dp to let the ConstraintLayout stretch it based on the constraints. ConstraintLayout() doesn't behave that way if you add a width(0.dp) modifier. In that case we need to translate it to fillMaxWidth() or fillMaxHeight().

For now we could just always translate 0dp to fillMaxWidth() or fillMaxHeight() if the node has any constraint set.

Introduced an API to for defining how an Attribute and a View Element can be parsed from XML to AST. This API has two Key interfaces, AttributeTransformer to define how an XML-Attribute is converted and Node Transformer to define how an entire XML-Element in is transformed. A Node Transformer can contain multiple AttributeTransformer, and will be automatically picked up by the NodeMatcher class, that scans the classpath for classes implementing the NodeTransformer interface and uses them to match a node name on a fitting NodeTransformer. The generated AST from that can be consumed by any class implementing the Visitor interface.

This work is just the first step for future optimizations. I am planning to enhance the AST to be able to apply an optimiser that can eliminate some nodes on the attributes (e.g. you can eliminate fillMaxHeight and fillMaxWidth and replace it with fillParent if both are present).

This adds a "Don't show this dialog next time" checkbox that applies for the current project. I can easily switch it if you prefer the setting to apply to the current workspace instead.

To clear the setting, you can remove it from .idea/workspace.xml in the current project.

I added this check to the LineWriter:

fun startLine(text: String = "") {
        if (builder.isNotEmpty() && checkLast('(').not()) {
            repeat(indent) { builder.append(INDENT) }
        }
        builder.append(text)
}

Where checkLast is

fun checkLast(char: Char): Boolean {
        return builder.last() == char
}

Because without the check instead of having as desired:

Button(onClick = {}, modifier = Modifier.width(100.dp).height(100.dp)) {
         Image(imageResource(R.drawable.ic_lock_power_off))
}

I get:

Button(onClick = {}, modifier = Modifier.width(100.dp).height(100.dp)) {
         Image(      imageResource(R.drawable.ic_lock_power_off))
}

#7, #59 added a confirmation dialog to the plugin, before pasting code. Like the Kotlin plugin we should offer a "Don't show this dialog next time" option.

Hi @pocmo , i've implemented: Check paste destination #6 Wrap code inserting Kotlin code in runWriteAction() #51 And Show a confirmation dialog before pasting #7

But i'm having two issues:

1. I can't figure out how to extract the strings from the confirmation dialog into a resource bundle. I know i can set " messages.MyPluginBundle" in the plugin.xml, but i cant use the keys in the code 🤷

2. The confirmation dialog has a "Don't show this dialog next time"-Checkbox. Right now, it does nothing. I can implement that the setting will be saved, but i think we would also need a page in the IntelliJ settings to reset this option. Just wanted to make sure, if this is wanted, before i implement it.

Issue: https://github.com/pocmo/recompose/issues/98 Add support for style attribute

Context

The plugin cannot handle a layout with a style attribute (like ?selectableItemBackground)

Changes

Convert attributes like ?selectableItemBackground in imageAttribute(selectableItemBackground)

Issue: https://github.com/pocmo/recompose/issues/96 Add support for MaterialCardView

Context

com.google.android.material.card.MaterialCardView extends androidx.cardview.widget.CardView and could use the same parser.

View available in:

com.google.android.material:material:1.2.1

Changes

CardView and MaterialCardView use the same parser: cardView()

internal fun XmlPullParser.node(): Node {
    require(START_TAG, null, null)

    return when (name) {

		// ...

        "androidx.cardview.widget.CardView",  
        "com.google.android.material.card.MaterialCardView" -> cardView()

		// ...
     }
}

com.google.android.material.card.MaterialCardView extends androidx.cardview.widget.CardView and could use the same parser.

View available in:

com.google.android.material:material:1.2.1

Plugin 'Recompose' (version '1.0') is not compatible with the current version of the IDE, because it requires build 202.* or older but the current build is AI-211.7628.21

gradle buildPlugin

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.intellij.ide.IdeEventQueue to constructor sun.awt.PostEventQueue(java.awt.EventQueue)
WARNING: Please consider reporting this to the maintainers of com.intellij.ide.IdeEventQueue
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

Android Studio Arctic Fox | 2020.3.1 Build #AI-203.7717.56.2031.7583922, built on July 26, 2021 Runtime version: 11.0.10+0-b96-7249189 amd64

Hi, tnx for plugin, is it possible to fix this error:

recompose.parser.Parser$ParserException: Unknown size value: @dimen/common_margin at recompose.parser.values.SizeKt.size(Size.kt:31) at recompose.parser.values.PaddingKt.padding(Padding.kt:29) at recompose.parser.xml.ViewKt.viewAttributes(View.kt:82) at recompose.parser.xml.viewgroup.LinearLayoutKt.linearLayout(LinearLayout.kt:33) at recompose.parser.xml.ViewKt.node(View.kt:51) at recompose.parser.xml.ViewGroupKt.viewGroupAttributes(ViewGroup.kt:37) at recompose.parser.xml.viewgroup.UnknownKt.unknown(Unknown.kt:31) at recompose.parser.xml.ViewKt.node(View.kt:69) at recompose.parser.xml.ViewGroupKt.viewGroupAttributes(ViewGroup.kt:37) at recompose.parser.xml.viewgroup.ConstraintLayoutKt.constraintLayout(ConstraintLayout.kt:32) at recompose.parser.xml.ViewKt.node(View.kt:65) at recompose.parser.xml.ViewGroupKt.viewGroupAttributes(ViewGroup.kt:37) at recompose.parser.xml.viewgroup.UnknownKt.unknown(Unknown.kt:31) at recompose.parser.xml.ViewKt.node(View.kt:69) at recompose.parser.xml.LayoutKt.layout(Layout.kt:37) at recompose.parser.Parser.parse(Parser.kt:62) at recompose.parser.Parser.parse(Parser.kt:53) at recompose.parser.Parser.parse(Parser.kt:37)

The parser seems to close a parent tag for EditText.

FrameLayout {
    EditText()
    View()
}

Will result in:

FrameLayout {
    EditText()
}
View()

Same occurs with LinearLayout.