Your library is great and I am just playing around with V2.

Can I somehow stop the validation process for a view with multiple rules after the first error has occured?

I have a use case with two rules for one edit text field. The first rule checks if the user name is at least 5 characters long. The second then calls a backend service to check if this user name is still avaliable. So I only want the second rule to be fired if the first one is okay.

Sorry if I missed something but based on the code in the Validator I have not seen such an option.

Rules ordering is done on validation and custom rules adding occurs before. If so, custom rules always have more priority and that's not true. Maybe, it's better to store order inside the Rule? So developer could add custom rules at runtime with proper priority.

Hi,

Is there anyway to tell Saripaar to validate fields only if they're not empty? If not, please implement this feature.

Thanks for this great library.

I beleive that it would be better to make Validator.registerAdapter() non-static method.

I just had whole Activity context leaked because of this method is static. If you do something like this in your activity:

void onCreate() {
  Validator.registerAdapter(MyCustomView.class, new ViewDataAdapter<MyCustomView, String>() {
    public String getData(MyCustomView view) {
       return view.getCustomText();
    }
   validator = new Validator();
}

then you automatically leak your Context, because it gets captured by anonymous class. And using anonymous classes for this kind of things is very common. So using static here makes it very easy to introduce a leak.

Besides by looking at the sources I don't see why this method needs to be global. Validator class seems to be designed to be used in local scope, i.e. inside an activity lifetime, so it seems that registerAdapter should live in that scope too, i.e. be non static.

I have such an EditText: @Password @Size(min = 6, message = "Enter at least 8 characters.") EditText editTxtPassword;

this rule works, except the case if my pass long enough. When my edittext has string with 6 chars It returns emty error

Hi Ragunath,

I understand from reading other issues that it is a feature. However, we've got a view that is layouted similar to an expandable list where the user can collapse sections of the view. Within these partly collapsed sections are input fields that we need to include in the validation. By collapsing a section all subviews are hidden (visibility=GONE), including the input fields.

I understand from your code that the check "if (view.isShown() & view.isEnabled()) ..." is fix coded and there is no configurable item that enables or disables this feature.

What do you think of making this configurable like "checkHidden = true" on rule level (with a default of false) or so? Or woudn't it be sufficient to change that if statement to "if (view.isEnabled())". Somebody who wants to exclude hidden fields from validation could still disable them.

As for now we are using @NotEmpty checks only on that view.

Any help is appreciated.

Cheers Hermann

There are cases where you want to run validation and get the response in a single thread. For example, when the user hits 'Done' on the keyboard on the last field you might want to validate all fields before submitting data to the server.

As far as I can see the only way to find out the validation result is in the onValidationSucceeded() callback, but in this multithreaded environment that doesn't know the trigger context (user just pressed 'Done' on the keyboard) so you end up having to set hacky workarounds with state variables in the Activity class which is undesirable.

Maybe validate(false) could return List<ValidationError> ?

Hi Sir, I came across with your library and I want to try it out. In your instruction Quick Start-step 1, there is an annotation, @NotEmpty , and when I open the link of your annotations, I can see several classes.

I tried above instruction but I can't find the class @NotEmpty, so I tried copying the code in your NotEmpty.class and create a copy in my project, but @ValidateUsing(NotEmptyRule.class) could not be found either.

So, I downloaded your main project and I found all those files.

My question is, why I could not find those files in your jar? do I need to include the source as dependency in my project?

Thank you so much.

I am using this library https://github.com/ragunathjawahar/android-saripaar to apply validations on my input fields like non empty, email etc.

I have two input fields and this is how I am applying validations. It is crashing my application. I checked validator variable is not null

MainActivity.java

@NotEmpty
private TextInputLayout client_id_input_layout;

@NotEmpty
private TextInputLayout access_code_input_layout;

@Inject
Validator validator;

@Override
protected void onCreate(Bundle savedInstanceState) {
	super.onCreate(savedInstanceState);
	....

	validator.setValidationListener(this);
}

@Override
public void onClick(View view) {
	if(isOnline())
		validator.validate();
	else
		Snackbar.make(mCoordinatorLayout, getString(R.string.network_error), Snackbar.LENGTH_LONG).show();
}

Validator.java

@Module
public class Validator {

	@Provides
	@Singleton
	com.mobsandgeeks.saripaar.Validator providesValidator(Application application) {
		return new com.mobsandgeeks.saripaar.Validator(application);
	}
}

StackTrace

Process: com.icici.iciciappathon, PID: 4555
java.lang.NullPointerException: Attempt to invoke virtual method 'void com.mobsandgeeks.saripaar.ValidationContext.setViewRulesMap(java.util.Map)' on a null object reference
   at com.mobsandgeeks.saripaar.Validator.createRulesSafelyAndLazily(Validator.java:479)
   at com.mobsandgeeks.saripaar.Validator.validate(Validator.java:330)
   at com.mobsandgeeks.saripaar.Validator.validate(Validator.java:295)
   at com.icici.iciciappathon.login.AuthenticationActivity.onClick(AuthenticationActivity.java:102)
   at android.view.View.performClick(View.java:5609)
   at android.view.View$PerformClick.run(View.java:22259)
   at android.os.Handler.handleCallback(Handler.java:751)
   at android.os.Handler.dispatchMessage(Handler.java:95)
   at android.os.Looper.loop(Looper.java:154)
   at android.app.ActivityThread.main(ActivityThread.java:6077)
   at java.lang.reflect.Method.invoke(Native Method)
   at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:865)
   at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:755)

in Validator class:

    public Validator(final Object controller) {
        assertNotNull(controller, "controller");
        mController = controller;
        mValidationMode = Mode.BURST;
        mSequenceComparator = new SequenceComparator();
        mViewValidatedAction = new DefaultViewValidatedAction();

        // Instantiate a ValidationContext
        if (controller instanceof Activity) {
            mValidationContext = new ValidationContext((Activity) controller);
        } else if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.HONEYCOMB
                && controller instanceof Fragment) {
            Activity activity = ((Fragment) controller).getActivity();
            mValidationContext = new ValidationContext(activity);
        }
        // Else, lazy init ValidationContext in #getRuleAdapterPair(Annotation, Field)
        // or void #put(VIEW, QuickRule<VIEW>) by obtaining a Context from one of the
        // View instances.
    }

If I pass in something other than Fragment or Activity I'll eventually get NPE when trying to access a ValidationContext:

java.lang.NullPointerException: Attempt to invoke virtual method 'void com.mobsandgeeks.saripaar.ValidationContext.setViewRulesMap(java.util.Map)' on a null object reference

I see two options:

1. the simple option is to just warn me with specific RTE
2. make this constructor private and overload with constructors that take in fragment and activities:

public Validator(Activity controller) {
    this(controller);
    this.mValidationContext = new ValidationContext((Activity)controller);
}

public Validator(Fragment controller) {
   this(controller);
    if(Build.VERSION.SDK_INT >= 11) {
        Activity activity = ((Fragment)controller).getActivity();
        this.mValidationContext = new ValidationContext(activity);
    } else {
        throw new RuntimeException("...")
    }
}

private Validator(Object controller) {
    assertNotNull(controller, "controller");
    this.mController = controller;
    this.mValidationMode = Validator.Mode.BURST;
    this.mSequenceComparator = new SequenceComparator();
    this.mViewValidatedAction = new DefaultViewValidatedAction();
}

Hello, first of all thank you so much such perfect library.

I am new with your library I have conditional based some field, can I validate that as well ? if yes then how.

Thanks, Ronak Amlani

In my case, I would like to check if the first Edittext matches with the second Edittext. But for this case, I can't use the @ConfirmPassword annotation since this is not a password I want to check the pin.

When i'm using android-saripaar in project with one module it's ok but if i'm using this library with multiple module project the problem is R,java is not final in library modules so i think you need to support R2 or create custom R class to use it with android-saripaar