...e list

Hi Roman,

First of all, thanks for your library.

I've discovered a bug in the library that is quite easy to reproduce: if you swipe the penultimate item of the list and just right after you start swiping the last element of the list (keep it pressed) before the performDismiss() method of the penultimate item gets called, the application throws an IndexOutOfBoundsException.

If I am not wrong, that happens because when you swipe the penultimate item, mAdapter.notifyDataSetChanged() gets called in the onDismiss() callback, the view gets refreshed, and MotionEvent.ACTION_UP gets called using the mDownPosition saved when MotionEvent.ACTION_DOWN. If performDismiss() gets called (depending on the X of the touch event), you might end up trying to remove an element with a stale position from the list. In case it is the last item of the list, that will lead to an IndexOutOfBoundsException.

I know the bug depends on the current implementation of the callback method onDismiss() (depends if you try to remove the item from the adapter). But I think that's one of the most common implementations.

I've just restored mDownPosition = ListView.INVALID_POSITION; just after calling mCallbacks.onDismiss(mListView, dismissPositions); in order to restore mDownPosition so I can avoid dismissing a view with a stale position when this happens.

This is just a quick fix to avoid the crash, I might be missing some other stuff. Please let me know if there's a better way to solve the issue.

Regards, Gerlac

When we have decided to dismiss the view, we should return true in onInterceptTouchEvent() to intercept the MotionEvent and stop the event being passed to the view.

Without this fix when a view is dismissed / hidden quickly it's possible to trigger the onClickListener and click the hidden view.

Allow swiping only when gesture seems to be horizontal (under 45°) and dismiss only (Velocity part) when mSwiping was true.

Animate swiping on ACTION_MOVE with -mSlop as offset for a smoother experience.

With a more elaborate adapter, for instance one that's touching a database (in my case the ObjectCursorAdapter), I noticed that the swipe to dismiss behavior was very jumpy and would flash the dismissed item briefly before removing it from the list.

Also, when I accessed the last item in the list object in onDismiss with adapter.getItem(position), I would receive null, stopping me from updating that object.

Adding a hook to alter objects before the dismiss occurs allowed me to update the object at that position and made the remove item much smoother (no flash of dismissed item).

It's only two lines of code, updated the docs and confirmed working in your sample app.

Only animate the view when needed. When a view is in 'animated' state, it will not be updated by the ListView if notifyDataSetChanged is invoked. So if you use checkable views in combination with this listener, the views won't be checked.

When the same listener is attached to the root view and a child view (like a EditText), the ACTION_CANCEL should be sent to the view receiving the events (like in the above case, EditText should not show the "Paste" option).

...omplete.

Bug: If layoutParams of dismissed view are WRAP_CONTENT, then this setting is overwritten with the original getHeight() of the View instead of returning to WRAP_CONTENT. This was breaking our list view cell's when they were being reused by the list view. They were no longer dynamically resizing but were instead locked to 'originalHeight' forever after.

I was using this Library : https://github.com/LeonardoCardoso/Animated-Expanding-ListView and the following Fix ( Performing the Cancel Animation if Swipping is true only ) solved my issue.

preDimiss Hook is useful for getting confirmation from user just before dismissing an item. Activity/Fragment can use this hook to do things like showing AlertDialog or Toast etc..! Thanks for this wonderful piece of code!