Hi,

I'm getting a crash when using Phrase.from("This is an {EXAMPLE}"); Throwing a 'Unexpected character 'E'; expected key.'

Could you add support for uppercase keys? It would help me since i'm not controlling the strings I receive.

Thank you !

It's a common pattern in US English to separate items in a 2-element list with a single "and" – e.g. "one and two". Larger lists may use commas to separate every element but the last, e.g. "one, two, and three".

ListPhrase takes separator patterns for each of these cases, and formats lists correctly based on their size.

Since list separators can be defined in strings.xml, they can also be localized by translators.

Hi there,

The following string and the invocation of Phrase got me this exception every time. Could someone take a look and tell me what went wrong? Thanks! : <string name="example_string">{aaa} (Now {bbb})</string>

Phrase.from(this, R.string.example_string)
                    .put("aaa", getAaa())
                    .put("bbb", getBbb())
                    .format()

This is the exception:

Exploded trying to parse content: java.lang.IllegalArgumentException: Missing closing brace: }
    at com.squareup.phrase.Phrase.key(Phrase.java:245)
    at com.squareup.phrase.Phrase.token(Phrase.java:221)
    at com.squareup.phrase.Phrase.<init>(Phrase.java:204)
    at com.squareup.phrase.Phrase.from(Phrase.java:112)
    at com.squareup.phrase.Phrase.from(Phrase.java:103)
    at com.squareup.phrase.Phrase.from(Phrase.java:94)

It's occasionally useful to be able to populate the Phrase parameter set without having access to Resources, and actually load the template and bind the parameters late. The current API does not support this well.

Hi,

would like to adopt the library but things like the camel-case bug #32 or missing plurals support #2 are kind of blockers to me. Some PRs are open for quite a while now. Can we expect updates in the near future?

Oracle JDK 7 no longer available; openJDK7 is missing an EC crypto provider needed to download gradle plugins, so I just removed the 7 compiler. We could pursue workarounds but they're a bit messy, see https://github.com/uber-java/tally/blob/2cea75ecc2f896dfd5e32b94bff71f211c8bde56/ci/before_install.sh#L6-L12

and gradle/gradle#2421

ListPhrase listFormatter = ListPhrase.from(" and ", ", ", and ");

String[] texts=new String[]{"Joe", "Jane", "John"};
ArrayList<CharSequence> bolds=new new ArrayList<>();

for(String t : texts){
     Spannable b = new SpannableString(t);
     boldString.setSpan(new StyleSpan(BOLD), 0, t.length(), Spannable.SPAN_INCLUSIVE_INCLUSIVE);
     bolds.add(b)
}
return listFormatter.join(bolds)

That doesn't show style while Phrase support for Spannable

CharSequence formatted = Phrase.from("Hi {first_name}, you are {orderBy} years old.") .put("first_name", firstName) .put("orderBy", age) .format();

when the string contains 'orderBy' it Throw IllegalArgumentException: Missing closing brace: }

Something like this?

<string name="xx"><color="@color/color_id">{a}</color> is {b}<color="#aabbcc">awesome?</color></string>

Allows setting text directly from the Phrase chain, similar to how Picasso does it.

Before:

  CharSequence greeting = Phrase.from("Hello {user}!").put("user", "Quinn").format();
  greetingTextView.setText(greeting);

Now:

  Phrase.from("Hello {user}!")
      .put("user", "Quinn")
      .into(greetingTextView);

Seeing as Jetpack Compose is the new hotness, it would be great to have support for building AnnotatedStrings. Options:

0. Yolo, add the Compose dependency and people can manually remove it if they care.
1. Fork
2. Do the okio/etc thing and change the artifact id to phrase2 and include Compose in that artifact. If somehow there are bugs that need to get fixed, in theory we can do a release of both artifacts
3. Separate phrase-compose artifact, make keys/keysToValues public, and add a method in the new artifact that reads them and builds an AnnotatedString

This mode unlocks the ability for consumers to disable span support. This enables writing pure unit tests that do not depend on SpannableStringBuilder which otherwise would require Robolectric to run and make the tests much much slower.

Fixed all warnings too.

@loganj @ChrisRenke @rjrjr

enhance tests readability by using ExpectedException instead of try/catch blocks. some brief explanation here : http://turhanoz.com/junit4-testing-exception/