As a new requirement in Android 12 and fixing https://github.com/square/seismic/issues/24.

The change is just expose a new start method that exposes an int parameter to configure the sensor delay.

Please, don't hesitate to ask me for changes if needed :)

In my application I have a feature like Google Maps' shake to feedback so I initialized the seismic inside my BaseActivity and extend every Activity from that. This causes leaks, is there another way to have shake detection in every activity I have?

Until now, shaking continuously for a long time (say, a second and a half) could cause hearShake() to be called several times. This change ensures that there is a period of immobility after the hearShake() call before the next shake can be recognized.

Given both magnitude and ACCELERATION_THRESHOLD are positive, the following are equivalent:

magnitude > ACCELERATION_THRESHOLD

magnitude * magnitude > ACCELERATION_THRESHOLD * ACCELERATION_THRESHOLD

The second one is more efficient.

On android 12 a new permission has been added when the sampling rate is set to 0 microseconds. Would be possible to have this value configurable? Are we able to detect the shake gesture with a sampling rate lower than 200 Hz?

The issue that I'm getting right now when initializing the ShakeDetector is this one:

java.lang.SecurityException: To use the sampling rate of 0 microseconds, app needs to declare the normal permission HIGH_SAMPLING_RATE_SENSORS.
        at android.hardware.SystemSensorManager$BaseEventQueue.enableSensor(SystemSensorManager.java:790)
        at android.hardware.SystemSensorManager$BaseEventQueue.addSensor(SystemSensorManager.java:710)
        at android.hardware.SystemSensorManager.registerListenerImpl(SystemSensorManager.java:209)
        at android.hardware.SensorManager.registerListener(SensorManager.java:823)
        at android.hardware.SensorManager.registerListener(SensorManager.java:730)
        at com.squareup.seismic.ShakeDetector.start(ShakeDetector.java:66)
        ...

In class "Demo" had next line:

package com.squareup.seismic.sample; 

This is a mistake, the correct value:

package main.java.com.squareup.seismic.sample;

I'm trying to do an app that send you notifications every time a certain seismic wave happens,and send you a notification to your phone if you have the app downloaded.

I've added this library to my android project, but I'm noticing that I've to shake it very hard to trigger the hearShake method, is there a way to set sensitivity? If not, could such methods be publicly exposed?

Bumps junit from 4.10 to 4.13.1.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Due to the workaround of keeping at least MIN_QUEUE_SIZE in the sample queue stale SensorEvents will be kept even after MAX_WINDOW_SIZE. It is therefore possible that a isShaking() event will be emitted to the listener immediately after restarting (start() -> stop() -> wait x seconds -> start()) because they don't get purged correctly. This is a very common use case when one uses it to start in onResume() and stops it in onPause().

Here is a minimal example on how to reproduce it:

https://gist.github.com/patrickfav/e6d6eb63fc0bea30f87b94d3e7b29c9c

When the user shakes in the MainActivity, the HearShakeActivity gets startet. After waiting arbitrary amount of seconds pressing back in the HearShakeActivity immediatly restarts HearShakeActivity. (I can reproduce it on my Nexus 6p; maybe slower devices cannot reproduce this bug)

By clearing the queue on stop(), start() will start with a clear sample queue without stale events from seconds/minutes ago. This should not break any contract, since it would be very unintuitive to expect the sample queue stretching over the stopped phase.

Regarding testing: unfortunately I did not find a way to manually create SensorEvents to test the detector's stop behavior. Making this testable would require some refactoring, which would make the whole project really verbose.

Disclaimer: I signed Individual Contributor License Agreement

The results show that the shaking occurs about seven times in two seconds. However, I want to increase the number of shaking measures. Can I increase the number of detections per second with the code in the library?

I put sd.stop(); in onPause(), onDestroy(), and onBackPressed() but when I leave the application and shake the device on my homescreen for example it still performs the specified action.

Samsung overrides motion gestures like shake and it seems like this library is not compatible with their modified Android system. If there is a secret device setting to make it work, please document it.

The test:

@Test public void testPurge() {
  ShakeDetector.SampleQueue q = new ShakeDetector.SampleQueue();
  q.add(1, true);
  q.add(2, true);
  q.add(3, true);
  q.add(4, true);
  q.add(5, true);
  q.add(6, true);
  q.add(7, true);
  q.add(8, true);
  q.add(9, true);
  assertThat(q.asList()).hasSize(9);
  q.purge(3);
  assertThat(q.asList()).hasSize(7);
  q.purge(8);
  assertThat(q.asList()).hasSize(4); // MIN_QUEUE_SIZE
}

The last assert fails, the size is 3.

I need to have way more sensitivity.

Half a second, and more than 75 % of samples is not acceptable for my use case. I can pick the phone from table and put it back withou triggering hearShake. And I've senstivity set to 10.

I need to detect the phone flipping over from synchronization cradle.