Hello @st235

Please add MVVM support

navController = Navigation.findNavController(this, R.id.nav_host_fragment);

So user can use this library with navigation component also. so user can handle only one activity and all fragment.

Thanks

hello @st235

sins the MVVM support it is awesome, but we need one more enhancement in the library, so Fragment not create every time when any bottom menu item clicked with MVVM

Thanks

Am I doing wrong here? Gradle implementation 'com.github.st235:expandablebottombar:1.5.1' xml <github.com.st235.lib_expandablebottombar.ExpandableBottomBar android:id="@+id/expandable_bottom_bar" android:layout_width="0dp" android:layout_height="wrap_content" android:layout_margin="20dp" app:exb_backgroundCornerRadius="25dp" app:exb_backgroundColor="#2e2e2e" app:exb_itemInactiveColor="#fff" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" />

package ng.com.obkm.bottomnavviewwithfragments;

import android.content.Intent; import android.os.Bundle; import android.support.annotation.NonNull; import android.support.design.widget.BottomNavigationView; import android.support.v4.app.Fragment; import android.support.v4.app.FragmentManager; import android.support.v7.app.AppCompatActivity; import android.support.v7.widget.Toolbar; import android.view.Menu; import android.view.MenuItem; import android.widget.Toast;

import ng.com.obkm.bottomnavviewwithfragments.home.HomeFragment;

public class MainActivity extends AppCompatActivity {

boolean doubleBackToExitPressedOnce = false;
final Fragment fragment1 = new HomeFragment();
final Fragment fragment2 = new DashboardFragment();
final Fragment fragment3 = new NotificationsFragment();
final FragmentManager fm = getSupportFragmentManager();
Fragment active = fragment1;
BottomNavigationView navigation;

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    Toolbar toolbar = (Toolbar) findViewById(R.id.toolbar);
    setSupportActionBar(toolbar);
    navigation = (BottomNavigationView) findViewById(R.id.navigation);
    navigation.setOnNavigationItemSelectedListener(mOnNavigationItemSelectedListener);
    setFragment(fragment1, "1", 0);
}


private BottomNavigationView.OnNavigationItemSelectedListener mOnNavigationItemSelectedListener
        = new BottomNavigationView.OnNavigationItemSelectedListener() {

    @Override
    public boolean onNavigationItemSelected(@NonNull MenuItem item) {
        switch (item.getItemId()) {
            case R.id.navigation_home:
                setFragment(fragment1, "1", 0);
                return true;
            case R.id.navigation_dashboard:
                setFragment(fragment2, "2", 1);
                return true;
            case R.id.navigation_notifications:
                setFragment(fragment3, "3", 2);
                return true;
        }
        return false;
    }
};

public void setFragment(Fragment fragment, String tag, int position) {
    if (fragment.isAdded()) {
        fm.beginTransaction().hide(active).show(fragment).commit();
    } else {
        fm.beginTransaction().add(R.id.main_container, fragment, tag).commit();
    }
    navigation.getMenu().getItem(position).setChecked(true);
    active = fragment;
}

@Override
public boolean onCreateOptionsMenu(Menu menu) {
    getMenuInflater().inflate(R.menu.main_menu, menu);
    return super.onCreateOptionsMenu(menu);
}

@Override
public boolean onOptionsItemSelected(MenuItem item) {
    int id = item.getItemId();

    if (id == R.id.action_settings) {
        startActivity(new Intent(MainActivity.this, SettingsActivity.class));
        return true;
    }

    return super.onOptionsItemSelected(item);
}

@Override
public void onBackPressed() {
    if (active == fragment1) {
        if (doubleBackToExitPressedOnce) {
            super.onBackPressed();
            return;
        }
        this.doubleBackToExitPressedOnce = true;
        Toast.makeText(this, "Please click BACK again to exit", Toast.LENGTH_SHORT).show();
    } else {
        setFragment(fragment1, "1", 0);
    }
}

}

I was using this library for like 1 year ago, and yesterday i update my Android Studio as well as other plugin upgrade (gradle, kotlin, sdk, etc).

when i try run my apps after update, the bottom bar only showing white box (i marked bottom bar location with red box)

I've tried from upgrading this library into 1.4.0 version, adding mavencentral() to project gradle, and checking code where it attach to navigation controller.

what could possibly go wrong? i can't find it. Please help

Here code what i use

MainActivity.kt val navController = Navigation.findNavController(this@MainActivity, R.id.nav_host_fragment) ExpandableBottomBarNavigationUI.setupWithNavController(binding.expandableBottomBar, navController)

activity_main.xml `

<github.com.st235.lib_expandablebottombar.ExpandableBottomBar
    android:id="@+id/expandable_bottom_bar"
    android:layout_width="match_parent"
    android:layout_height="80dp"
    android:layout_marginHorizontal="15dp"
    android:layout_marginBottom="10dp"
    android:background="?android:attr/windowBackground"
    android:paddingVertical="20dp"
    app:exb_backgroundCornerRadius="15dp"
    app:exb_itemInactiveColor="#B5B5B5"
    app:exb_items="@menu/bottom_nav_menu"
    app:layout_constraintBottom_toBottomOf="parent"
    app:layout_constraintEnd_toEndOf="parent"
    app:layout_constraintStart_toStartOf="parent" />`

mobile_navigation.xml `

<fragment
    android:id="@+id/navigation_notification"
    android:name="com.catty.app.fragments.NotificationFragment"
    android:label="@string/notification"
    tools:layout="@layout/fragment_notification" />

<fragment
    android:id="@+id/navigation_profile"
    android:name="com.catty.app.profile.ProfileFragment"
    android:label="@string/profile"
    tools:layout="@layout/fragment_profile" />`

When using version 1.4.0, studio cannot find ExpandableBottomBar, when I changed to version 1.3.0, it can run normally. I have tried to clear the cache. I don't know if this is an example?

I was unable to replicate this issue while using a regular user app but when in use with AOSP, I noticed an issue when adjusting font size to anything above 'Default'.

Test:

• Import aar to AOSP
• Utilize the library
• Adjust the font size to Large or above under Settings

See image to notice issue described above

• https://i.imgur.com/zm4s2mz.jpg

Here is my menu/bottom.xml

<?xml version="1.0" encoding="utf-8"?>
<menu
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:android="http://schemas.android.com/apk/res/android">

    <item
        android:id="@+id/bottom_home"
        android:title="@string/menu_home"
        app:exb_color="#000000"
        app:exb_icon="@drawable/round_home_black_24" />
    ...
</menu>

and here is my activity_main.xml

...
<github.com.st235.lib_expandablebottombar.ExpandableBottomBar
            android:id="@+id/bottom_bar"
            android:layout_width="match_parent"
            android:layout_height="80dp"
            android:layout_margin="20dp"
            app:layout_behavior="github.com.st235.lib_expandablebottombar.behavior.ExpandableBottomBarScrollableBehavior"
            app:layout_constraintBottom_toBottomOf="parent"
            app:exb_backgroundCornerRadius="10dp"
            app:exb_itemInactiveColor="#ccc"
            app:exb_items="@menu/bottom"
            />
...

If I try to use the @drawable/round_home_black_24 drawable icon in another view, the tint of the drawable is also applied to #ccc in the other view.

here is image.

The original color of the drawable is black, and I haven't set the tint property.

First of all thank you for make this library :)

Is this the only way to remove menuitems title?

<item
   android:id="@+id/home"
   android:title=""
   ... />

It has some padding on title space when I select it. but I don't want it. are there any other way to remove it?

I just started a fresh project and wanted to add this library to my app, but i cant add items to the bottom bar and the method doesnt work. It is a java project but as far as I know it shouldnt matter.

How can I fix this? I dont think I did anything wrong since there is not much that I can do wrong for this library.

Hello @st235

Please describe some code peace, how to use setOnItemSelected listener in java class, and describe add multiple fragments. it is very useful library

Thanks