-Fixed issue ( notifyDataSetChanged was not working when background data attached with DragNDropSimpleadapter was changed). This was causing the app to crash due to index out of bound exception.

• Updated Support Library Version to 21.0.3
• Updated Android Target Version to 5.0.1

Now the build system of Android is gradle so I added the build.gradle script.

In the DragNDropListView factorize the call to the getSystemService(Context.WINDOW_SERVICE) so to not waste CPU cycle to obtain something already calculated.

I think this patch addresses the crash caused from dropping an item on the footer when present.

 08-01 17:49:09.628  30242-30242/? E/MessageQueue-JNI: java.lang.ArrayIndexOutOfBoundsException: length=7; index=7
 at com.terlici.dragndroplist.DragNDropCursorAdapter.onItemDrop(DragNDropCursorAdapter.java:97)
 at com.terlici.dragndroplist.DragNDropListView.stopDrag(DragNDropListView.java:249)
 at com.terlici.dragndroplist.DragNDropListView.onTouchEvent(DragNDropListView.java:156)

If the ListView has a footer a ClassCastException is thrown

E/AndroidRuntime(17730): java.lang.ClassCastException: android.widget.HeaderViewListAdapter cannot be cast to com.terlici.dragndroplist.DragNDropAdapter
E/AndroidRuntime(17730):    at com.terlici.dragndroplist.DragNDropListView.startDrag(DragNDropListView.java:163)
E/AndroidRuntime(17730):    at com.terlici.dragndroplist.DragNDropListView.onTouchEvent(DragNDropListView.java:127)
E/AndroidRuntime(17730):    at android.view.View.dispatchTouchEvent(View.java:7253)

This branch tries to address this problem.

I noticed, that if you set the drag handler to a view whose parent is not the view generated by the adapter, the dragging-enabled area is not calculated right.

To test this replace the content of testitem.xml (DragNDropListApp) with

<TextView
    android:id="@+id/text"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:text="Large Text"
    android:textAppearance="?android:attr/textAppearanceLarge" />

<FrameLayout
    android:layout_width="match_parent"
    android:layout_height="match_parent">

    <ImageView
        android:id="@+id/handler"
        android:layout_width="60px"
        android:layout_height="60px"
        android:src="@android:drawable/btn_star_big_on"
        android:layout_marginLeft="8px"
        />
</FrameLayout>

Hi

with Nexus 7 , To start drag a list was easy. I just touch a list and just drag.

with Nexus 5x ( android 6 ), To start drag is not easy. Almost case, I can not drag at all.

Any idea ?

Got a crash from one user. Making a null pointer check will solve this issue I guess in stopDrag(), e.g.

        if (item != null) {
            item.setDrawingCacheEnabled(false);
            item.destroyDrawingCache();

            item.setVisibility(View.VISIBLE);
        }

Android: 5.0.1 Manufacturer: samsung Model: SM-N915G

java.lang.NullPointerException: Attempt to invoke virtual method 'void android.view.View.setDrawingCacheEnabled(boolean)' on a null object reference
    at com.terlici.dragndroplist.DragNDropListView.stopDrag(SourceFile:265)
    at com.terlici.dragndroplist.DragNDropListView.onTouchEvent(SourceFile:162)
    at android.view.View.dispatchTouchEvent(View.java:8975)
    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2698)
    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2410)
    at android.widget.AbsListView.dispatchTouchEvent(AbsListView.java:5308)
    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2709)
    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2425)
    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2709)
    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2425)
  [SKIPPED]

I used the same layouts for row and main activity as they are on the main page, except I changed the list width to 200dp.

When I do this and start dragging the view, the star (drag handler) shows up on the wrong place. Instead of showing where the it is shown in the list it shows up in the middle of the screen.

Here is the layout file:

<com.terlici.dragndroplist.DragNDropListView
    android:id="@id/android:list"
    android:layout_width="wrap_content"
    android:layout_height="match_parent" />

Here is the row layout:

<ImageView
    android:id="@+id/handler"
    android:layout_width="60px"
    android:layout_height="60px"
    android:src="@android:drawable/btn_star_big_on"
    android:layout_marginLeft="8px"
    />

<TextView
    android:id="@+id/text"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:text="Large Text"
    android:textAppearance="?android:attr/textAppearanceLarge" />

And here is the main activity code: package com.example.ddexample;

import java.util.ArrayList; import java.util.Hashtable;

import android.app.Activity; import android.content.Context; import android.os.Bundle;

import com.terlici.dragndroplist.DragNDropListView; import com.terlici.dragndroplist.DragNDropSimpleAdapter;

public class MainActivity extends Activity {

@Override
protected void onCreate(Bundle savedInstanceState)
{
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    DragNDropListView list = (DragNDropListView) findViewById(android.R.id.list);

    ArrayList<Hashtable<String, String>> xxx = new ArrayList<Hashtable<String, String>>();
    for (int a = 0; a < 100; a++)
    {
        Hashtable<String, String> fsa = new Hashtable<>();
        fsa.put(String.valueOf(a), String.valueOf(a));

        xxx.add(fsa);
    }
    DragNDropSimpleAdapter adapter = new DragNDropSimpleAdapter((Context) this, xxx, R.layout.row, new String[] { "1" }, new int[] { R.id.text },
            R.id.handler);

    list.setDragNDropAdapter(adapter);

}

}