Bumps git from 1.5.0 to 1.11.0.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Currently we only support uploading image & video files in the app. A user is asking to upload mp3 files for example (#144231-h). We should probably support every file type we currently support in wp-admin.

Summary with a list of remaining work can be found pOhUr-47V-p2 + comments.

The UI still need to be refined, but major features are all there. We want to start testing new Stats for real asap, and meanwhile refine stats UI with smaller PRs.

Keeping track of opening issues here:

• [x] There's no selection highlight on any of the tappable views, which is even more important on Lollipop where ripples are used. The simplest way to provide this is to use android:background="?android:selectableItemBackground" on any tappable view (this will automatically provide the ripple on Lollipop and a selection highlight on earlier version).
• [x] Try to get rid of the setEntryTextViewClickListener() hack. See comment below
• [x] Make sure the correct date/datetime for the blog. Seems there is a offset of 1hr.
• [x] I recommend selecting the "Stats" folder in Android Studio then selecting Analyze > Inspect Code > Current Directory
• [x] The selection highlight for list items seems off. It should highlight the entire row - including padding - but instead it highlights just the text.

Mobile request originally reported by @rachelmcr

WPAndroid 6.8 includes this change:

>    Changed the post list behavior on tap: open the editor instead of the preview.

This behavior feels right to me, but now I can’t figure out how to revert local changes on a post. In the past, here’s how it worked:

    Open a published post.
    Make edits to the post.
    Tap the back arrow to exit the editor. (Edits are saved as local changes.)
    Tap on the post to open the preview.
    Tap on “Revert” at the bottom of the preview to revert local changes.

Now, I can’t figure out how to revert those local changes. I don’t see a prompt anywhere, and even if I open the post in the editor and undo the change I made locally the post still shows as having local changes. I can’t find where to revert them.

**Update**

After starting this post, but before publishing it, I realized that I could choose “Preview” on the post list and revert the local changes from that preview (since the preview was where I had that option before). However, it doesn’t feel at all intuitive to go to the preview to revert local changes on a post.

Could we include a toast message or other prompt to save or revert local changes when the user opens the post in the editor? That’s where I was looking for the revert option, and it seems more intuitive to include that as part of the editor instead of the post preview.

Follow ups by: @catehstn

the best thing to do is to track this as some design work surrounding Aztec and posting and then close this.

@0nko

[...] a Discard button could be added to the activity menu, which is shared by all editors.

Fatal Exception: java.lang.IllegalArgumentException: reportSizeConfigurations: ActivityRecord not found for: Token{e1fb44f ActivityRecord{8954eaed0 u0 org.wordpress.android/.ui.main.WPMainActivity t13 f}}
       at android.os.Parcel.readException(Parcel.java:1697)
       at android.os.Parcel.readException(Parcel.java:1646)
       at android.app.ActivityManagerProxy.reportSizeConfigurations(ActivityManagerNative.java:8325)
       at android.app.ActivityThread.reportSizeConfigurations(ActivityThread.java:3069)
       at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3012)
       at android.app.ActivityThread.-wrap14(ActivityThread.java)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1650)
       at android.os.Handler.dispatchMessage(Handler.java:102)
       at android.os.Looper.loop(Looper.java:154)
       at android.app.ActivityThread.main(ActivityThread.java:6688)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1468)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1358)

When you create a post and you hit “publish now” a toast “Device is offline, changes saved locally” is shown

Decision

Android

• [x] Improve labels according to the design https://github.com/wordpress-mobile/WordPress-Android/issues/10207
• [x] Add support for the Cancel action https://github.com/wordpress-mobile/WordPress-Android/issues/10206
• [ ] Add support for trashing/restoring posts in offline https://github.com/wordpress-mobile/WordPress-Android/issues/10205
• [x] Automatically upload all local changes not just local drafts https://github.com/wordpress-mobile/WordPress-Android/issues/10174

I wanted to open this PR to get some early feedback. @tonyr59h and I were discussing that his "Site Settings" implementation might have some components we can use in "My Profile" as well. I am also not completely sure I have the best approach to a couple things.

The first question I had is about the layout. When we were working on the v1 of Calypsoification of the app with @nbradbury we opted not to use a list view for the Me fragment and I've taken a similar approach. I've used styles extensively here, so the code feels clear to me and there is not much need for a lot of switch statements. Having said that, it looks like "Site Settings" is implemented with list view, so I wanted to check in if I had the best approach for this.

My second question is about the usage of dialogs. I have looked into the WPAlertDialogFragment and it doesn't have a builder with an input in it. So for now, I have added the dialog inside the MyProfileActivity. Should I be looking to move that implementation to WPAlertDialogFragment instead? Also, note that the current dialog only works for "first name" and I thought I'd pass a tag to showInputDialog method and use a switch statement to make it work for all labels. I actually wanted to make it work with some kind of callback mechanism but couldn't really find a way to do that. Would that be possible? If not, I don't think the method would be generic enough to add inside of WPAlertDialogFragment.

For reference, here is the complete design for my profile page: https://cloudup.com/cGvJQYVBE0B And here are some screenshots from the actual implementation: https://cloudup.com/ciJn7zQjKfx

Anyone can review the PR, I am just ping Maxime to add a name here. Thanks! Needs review: @maxme

Merge Instructions:

1. ~Review and approve (don't merge) - https://github.com/wordpress-mobile/gutenberg-mobile/pull/4361~
2. ~Review this PR~
3. ~Merge Aztec https://github.com/wordpress-mobile/AztecEditor-Android/pull/946/files~
4. ~Merge Stories https://github.com/Automattic/stories-android/pull/717~
5. ~Merge GB PR - https://github.com/wordpress-mobile/gutenberg-mobile/pull/4361~
6. ~Merge GB PR which updates Aztec Version - it doesn't exist yet~
7. ~Update GB hash/version in this repo~
8. ~Review and Merge upgrade of test dependencies - https://github.com/wordpress-mobile/WordPress-Android/pull/16170 (technically not a blocker)~
9. ~Merge the branch in .mobile-secrets into trunk~
10. ~Update hash and branch in .configure~ (9f811ea608958fb7acbe781672b4c4c91318c5d4)
11. ~Remove "Not ready for merge" label~
12. ~Merge this PR~
13. Optional: Ping the team that they can change android.enableJetifier=true to android.enableJetifier=false in their gradle.properties or run ./gradlew configureApply.

This PR migrates all libraries to versions which are migrated to AndroidX so we can disable jetifier on our builds. Jetifier was always intended to be used only temporarily and is planned to be removed from future versions of AGP.

List of changes

• Bumps Stetho version to 1.6.0 - the only change is that the version is migrated to AndroidX - https://github.com/facebook/stetho/releases
• Bumps ExoPlayer from 2.9.3 to 2.12.3 -> this was the most challenging task as ExoPlayer is used in both MediaPreivewFragment and Gutenberg-Mobile => we had to bump the version in both Gutenberg and MediaPreviewFragment. (This work isn't done yet, the GB part is still WIP)
• Updates WordPress utils version to a version which is migrated to AndroidX -> I bumped the version in all the modules to make the version consistent
• Adds our S3 repo to Analytics and Networking modules so the new version of WordPress utils is reachable
• Disables jetifier - updated gradle.properties and .configure
• "Manually" (using cmd tool) Jetified the Tenor library since it hasn't been updated since 2018 and I don't think it'll get updated any time soon
• Updated Aztec version with version that uses the updated version of WordPress utils

To test: Make sure to disable Jetifier in your local gradle.properties => Smoke test the app - anything you can think of.

1. Open Media Library
2. Open a detail of a video
3. Tap on the preview
4. Make sure the preview is displayed correctly and you can play the video

1. Create a new post
2. Add image block
3. Select "Choose from Tenor"
4. Type "Cat"
5. Add a gif

1. Create a new post
2. Add Cover block
3. Add Video
4. Choose a video file
5. Make sure the video preview works

Regression Notes

1. Potential unintended areas of impact

• Video previews (media library)
• Video blocks in Gutenberg
• Adding gifs from Tenor

2. What I did to test those areas of impact (or what existing automated tests I relied on) The above "to test" section

3. What automated tests I added (or what prevented me from doing so)

None - this is a technical improvement which doesn't change the UX

PR submission checklist:

• [x] I have completed the Regression Notes.
• [x] I have considered adding accessibility improvements for my changes.
• [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

It appears we're getting a crash specific to Android devices with Android 8.x, prevalently Huawei devices.

The relevant bits of the stack trace:

Fatal Exception: java.lang.ArrayIndexOutOfBoundsException: length=79; index=-19
       at android.text.DynamicLayout.getBlockIndex(DynamicLayout.java:646)
       at android.widget.Editor.drawHardwareAccelerated(Editor.java:1744)
       at android.widget.Editor.onDraw(Editor.java:1713)
       at android.widget.TextView.onDraw(TextView.java:7034)
       at android.view.View.draw(View.java:19314)
       at android.view.View.updateDisplayListIfDirty(View.java:18250)
       at android.view.View.draw(View.java:19042)
       at android.view.ViewGroup.drawChild(ViewGroup.java:4271)
       at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4054)
       at android.view.View.updateDisplayListIfDirty(View.java:18241)
       at android.view.View.draw(View.java:19042)
       at android.view.ViewGroup.drawChild(ViewGroup.java:4271)
       at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4054)
       at android.view.View.updateDisplayListIfDirty(View.java:18241)
       at android.view.View.draw(View.java:19042)
       at android.view.ViewGroup.drawChild(ViewGroup.java:4271)
       at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4054)
       at android.view.View.draw(View.java:19317)
       at android.widget.ScrollView.draw(ScrollView.java:1777)
       at android.view.View.updateDisplayListIfDirty(View.java:18250)
       at android.view.View.draw(View.java:19042)
       at android.view.ViewGroup.drawChild(ViewGroup.java:4271)
       at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4054)
       at android.view.View.draw(View.java:19317)
       at android.view.View.updateDisplayListIfDirty(View.java:18250)
       at android.view.View.draw(View.java:19042)
       at android.view.ViewGroup.drawChild(ViewGroup.java:4271)
       at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4054)
       at android.view.View.draw(View.java:19317)
       at android.support.v4.view.ViewPager.draw(ViewPager.java:2420)
       at android.view.View.updateDisplayListIfDirty(View.java:18250)
       at android.view.View.draw(View.java:19042)
       at android.view.ViewGroup.drawChild(ViewGroup.java:4271)
       at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4054)
       at android.view.View.updateDisplayListIfDirty(View.java:18241)
       at android.view.View.draw(View.java:19042)
       at android.view.ViewGroup.drawChild(ViewGroup.java:4271)
       at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4054)
       at android.view.View.updateDisplayListIfDirty(View.java:18241)
       at android.view.View.draw(View.java:19042)
       at android.view.ViewGroup.drawChild(ViewGroup.java:4271)
       at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4054)
       at android.view.View.updateDisplayListIfDirty(View.java:18241)
       at android.view.View.draw(View.java:19042)
       at android.view.ViewGroup.drawChild(ViewGroup.java:4271)
       at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4054)
       at android.view.View.updateDisplayListIfDirty(View.java:18241)
       at android.view.View.draw(View.java:19042)
       at android.view.ViewGroup.drawChild(ViewGroup.java:4271)
       at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4054)
       at android.view.View.updateDisplayListIfDirty(View.java:18241)
       at android.view.View.draw(View.java:19042)
       at android.view.ViewGroup.drawChild(ViewGroup.java:4271)
       at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4054)
       at android.view.View.draw(View.java:19317)
       at com.android.internal.policy.DecorView.draw(DecorView.java:915)
       at android.view.View.updateDisplayListIfDirty(View.java:18250)
       at android.view.ThreadedRenderer.updateViewTreeDisplayList(ThreadedRenderer.java:684)
       at android.view.ThreadedRenderer.updateRootDisplayList(ThreadedRenderer.java:690)
       at android.view.ThreadedRenderer.draw(ThreadedRenderer.java:804)
       at android.view.ViewRootImpl.draw(ViewRootImpl.java:3199)
       at android.view.ViewRootImpl.performDraw(ViewRootImpl.java:2997)
       at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2526)
       at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1515)
       at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:7266)
       at android.view.Choreographer$CallbackRecord.run(Choreographer.java:981)
       at android.view.Choreographer.doCallbacks(Choreographer.java:790)
       at android.view.Choreographer.doFrame(Choreographer.java:721)
       at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:967)
       at android.os.Handler.handleCallback(Handler.java:808)
       at android.os.Handler.dispatchMessage(Handler.java:101)
       at android.os.Looper.loop(Looper.java:166)
       at android.app.ActivityThread.main(ActivityThread.java:7529)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:245)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:921)

It seems likely that this is related to #8827 – both are platform-specific Android 8 issues.

reference: 5a76a4fa8cb3c2fa634286c6-fabric reference: 5af4233111e9fa0aa513dfa0-fabric marked as high priority as it's happening ~35 times/day and affecting ~800 users

A user requested that the app have a dark theme instead of the current holo lite theme: ​http://android.forums.wordpress.org/topic/switch-themes-feature?replies=1

Sentry Issue: https://sentry.io/share/issue/136cee38cb79491db456071ee0c686a0/

NotFoundException: Unable to find resource ID #0x7f0800bb
    at org.wordpress.android.util.widgets.WPTextInputLayout.<init>(WPTextInputLayout.java:20)
    at org.wordpress.android.login.widgets.WPLoginInputRow.init(WPLoginInputRow.java:67)
    at org.wordpress.android.login.widgets.WPLoginInputRow.<init>(WPLoginInputRow.java:58)
    at org.wordpress.android.login.LoginBaseFormFragment.createMainView(LoginBaseFormFragment.java:100)
    at org.wordpress.android.login.LoginBaseFormFragment.onCreateView(LoginBaseFormFragment.java:106)
...
(60 additional frame(s) were not displayed)

NotFoundException: Drawable (missing name) with resource ID #0x7f0800bb
NotFoundException: File res/drawable-v21/design_password_eye.xml from drawable resource ID #0x7f0800bd
    at org.wordpress.android.util.widgets.WPTextInputLayout.<init>(WPTextInputLayout.java:20)
    at org.wordpress.android.login.widgets.WPLoginInputRow.init(WPLoginInputRow.java:67)
    at org.wordpress.android.login.widgets.WPLoginInputRow.<init>(WPLoginInputRow.java:58)
    at org.wordpress.android.login.LoginBaseFormFragment.createMainView(LoginBaseFormFragment.java:100)
    at org.wordpress.android.login.LoginBaseFormFragment.onCreateView(LoginBaseFormFragment.java:106)
...
(49 additional frame(s) were not displayed)

NotFoundException: Drawable org.wordpress.android:drawable/design_password_eye with resource ID #0x7f0800bd
InvocationTargetException: None
    at org.wordpress.android.login.widgets.WPLoginInputRow.init(WPLoginInputRow.java:67)
    at org.wordpress.android.login.widgets.WPLoginInputRow.<init>(WPLoginInputRow.java:58)
    at org.wordpress.android.login.LoginBaseFormFragment.createMainView(LoginBaseFormFragment.java:100)
    at org.wordpress.android.login.LoginBaseFormFragment.onCreateView(LoginBaseFormFragment.java:106)
...
(37 additional frame(s) were not displayed)

InflateException: Binary XML file line #21: Error inflating class org.wordpress.android.util.widgets.WPTextInputLayout
InflateException: Binary XML file line #21: Binary XML file line #21: Error inflating class org.wordpress.android.util.widgets.WPTextInputLayout
InvocationTargetException: None
    at org.wordpress.android.login.LoginBaseFormFragment.createMainView(LoginBaseFormFragment.java:100)
    at org.wordpress.android.login.LoginBaseFormFragment.onCreateView(LoginBaseFormFragment.java:106)
...
(24 additional frame(s) were not displayed)

InflateException: Binary XML file line #26: Error inflating class org.wordpress.android.login.widgets.WPLoginInputRow
InflateException: Binary XML file line #26: Binary XML file line #26: Error inflating class org.wordpress.android.login.widgets.WPLoginInputRow

Binary XML file line #26: Binary XML file line #26: Error inflating class org.wordpress.android.login.widgets.WPLoginInputRow

Expected behavior

That the toggle works as expected or that it is not there.

Actual behavior

Currently you see a autoupdate toggle for plugins on self hosted sites.

Steps to reproduce the behavior

Login to a self hosted site. Navigate to Plugins > any plugin. Notice that you see a toggle a plugin to be autoupdate able.

Tested on Simulator, WPAndroid 21.3

Expected behavior

Currently if you are running WordPress app you should be able to delete + deactivate the Jetpack plugin.

Actual behavior

On your self hosted site you currently can't delete and deactivate the Jetpack plugin. Steps to reproduce the behavior

Login to a self hosted site as an Admin. Navigate to Plugins > Jetpack Notice that you can't deactive or delete the Jetpack plugin.

Tested on Simulator WPAndroid 21.3

Expected behavior

I expect the Overlay screen to rotate as the device rotates and UI to change appropriately.

Actual behavior

When rotating the device the webpage opens for the Learn more at jetpack.com.

Steps to reproduce the behavior

1. I was testing this PR when I saw it, though this PR is merged in by now.
2. Enable Phase 2 by going to App Settings > App Debug Settings > select the check box for jp_removal_two.

Tested on [device], Android [version], WPAndroid [version]

Samsung A51, Android 12, WPAndroid Trunk (as of 1/04/2023).

We must use READ_MEDIA_IMAGES, READ_MEDIA_VIDEO and READ_MEDIA_AUDIO instead of READ_EXTERNAL_STORAGE.

https://developer.android.com/about/versions/13/behavior-changes-13#granular-media-permissions

Android 13 users encounter a permission dialog at the first launch of the app. We should control when we show the permission dialog for better UX.

https://developer.android.com/about/versions/13/changes/notification-permission Internal P2 post: pbArwn-5EG-p2

Fixes Partially #17334

This PR adds the Jetpack powered branding to the Themes screen starting from Phase Two of Features removal.

To test:

Jetpack Branding on the Themes screen should be visible starting from Phase Two of Features removal (jp_removal_two), while it should be hidden when all Jetpack removal flags are disabled or when Phase One is started.

There are 2 effective scenarios:

• Not Branded
  • In this scenario the Jetpack powered branding should not be visible
  • This phase is active when:
    • All Jetpack removal flags are disabled
    • The jp_removal_one flag is enabled
• Branded
  • In this scenario the Jetpack powered branding should be visible on Themes screen
  • This phase is active when any of the following features removal flags are enabled:
    • jp_removal_two
    • jp_removal_three
    • jp_removal_four

The change the features removal flags:

• Go to Me → App Settings → Debug settings and toggle the jp_removal_NNN flags (e.g. jp_removal_two).

Test using the following steps in each scenario:

Testing Steps

1. Open the WordPress app and login
2. Toggle one of the feature removals flags based on the above notes
3. Go to My Site → Menu tab
4. From menu, under 'Look and Feel' tap Themes
5. If in 'Not Branded' scenario
   • Expect to see no Jetpack powered branding
6. If in 'Branded' scenario:
   1. Expect the Jetpack powered banner to be visible at the bottom of the screen
   2. Tap the banner
   3. Expect the WordPress is better with Jetpack bottom sheet to be displayed
   4. tap the Try the new Jetpack app button
      1. If Jetpack app is not installed it should open the Play Store to install it
      2. If Jetpack app is installed, it should open
7. Go back to the WordPress app
8. Scroll down on the Themes screen
9. Expect the Jetpack powered banner to hide
10. Scroll back to top
11. Expect the Jetpack powered banner to show

Screenshots

| Not Branded | Branded | | - | - | | | |

Regression Notes

1. Potential unintended areas of impact Themes screen (WordPress & Jetpack app).

2. What I did to test those areas of impact (or what existing automated tests I relied on) Manual testing.

3. What automated tests I added (or what prevented me from doing so) Added tests for the new logic to JetpackFeatureRemovalBrandingUtilTest.

PR submission checklist:

• [x] I have completed the Regression Notes.
• [x] I have considered adding accessibility improvements for my changes.
• [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.