I have 2 fragments Add and Profile and I have public void onActivityResult in both of them. I get same errors in both of them: Uri image = result.getUri(); and Uri uri = result.getUri(); can you help me fix it?

Phone Model: Xiomi Redmi K20 Pro Version: Android 11 (RQ1.200826.002) CanHub Version: 3.3.5

I tried your sample project & run it. But it didn't work on my phone. Also, I uploaded a video for the issue.

https://www.youtube.com/watch?v=MY-bo92LFeo

Please check & replay.

🚨🚨 Not working in android 11

• Lib Version 3.2.2

Not working on my device (Poco M2 Pro Android 11 MIUI 12.0.1). CropView doesn't open after chosing the image, neither from gallery nor from camera. The activity simply gets finished. In the sample code it works when "Outside Camera and Start(Uri)' is selected. In the rest of the cases (refer sample code) it throws following error: --Library Camera, Start(), Custom Option : "cropping image was cancelled by the user" --Custom Selector Title... : "picking image failed" --Library show pick option... : "picking image failed"

To Reproduce Steps to reproduce the behavior:

1. Launch the sample app
2. Click on "Sample CallingCrop Image"
3. Click on "Library, Camera, Start(), Custom Option"
4. Pick image from gallery or click using camera
5. See the toast message

Expected behavior CropView should open on clicking the image in the gallery or after clicking on done icon if clicked from camera and uri should be returned in the required activity

**Smartphone **

• Device: Poco M2 Pro (MIUI 12.0.1)
• OS: Android 11

Additional context In parseResult method in PickImageContract class the result code is always 0 so the Activity.RESULT_CANCELED is called everytime. Also in CropImageActivity: private val pickImage: ActivityResultLauncher = registerForActivityResult(PickImageContract()) { onPickImageResult(it) } The returned Uri is always null

Description

Today the user can use the library to pick images from camera, gallery or documents

But the user cannot select that is from camera only, for example. So we need to add a parameter to the contract that define which intents we will use for selection.

Possible solution:

PickImageContract would receive a data class, like we have in CropImageContract and this data class will contain booleans for each type of selection camera/gallery/etc in the case that if you only choose one it open directly

• 2.0.3

Describe the bug A user that opts to take a photo can capture a picture and upon accepting the photo (aka, tapping on the check mark) they are returned to destination that launched CropImageActivity.

What's happening is an NPE is thrown (see below) when user accepts the photo, CropImageActivity.onActivityResult is called with resultCode == RESULT_CANCELED.

2021-02-10 09:45:14.860 6815-6815/? E/CAM_StateMachine: Failed to process event: com.android.camera.captureintent.event.EventTapOnConfirmPhotoButton@f96e55

2021-02-10 09:45:14.861 6815-6815/? E/AndroidRuntime: FATAL EXCEPTION: main Process: com.android.camera2, PID: 6815 java.lang.NullPointerException at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:890) at com.google.common.base.Optional.of(Optional.java:103) at com.android.camera.captureintent.state.StateSavingPicture.onEnter(StateSavingPicture.java:77) at com.android.camera.captureintent.stateful.StateMachineImpl.jumpToState(StateMachineImpl.java:62) at com.android.camera.captureintent.stateful.StateMachineImpl.processEvent(StateMachineImpl.java:110) at com.android.camera.captureintent.state.StateOpeningCamera$9.onClick(StateOpeningCamera.java:307) at android.view.View.performClick(View.java:7448) at android.view.View.performClickInternal(View.java:7425) at android.view.View.access$3600(View.java:810) at android.view.View$PerformClick.run(View.java:28305) at android.os.Handler.handleCallback(Handler.java:938) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loop(Looper.java:223) at android.app.ActivityThread.main(ActivityThread.java:7656) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)

To Reproduce Steps to reproduce the behavior:

1. From CropImageActivity, select Camera option
2. Accept permissions if needed
3. Take photo
4. Accept Photo
5. CropImageActivity is cancelled, NPE reported above is thrown.

Expected behavior

1. From CropImageActivity, select Camera option
2. Accept permissions if needed
3. Take photo
4. Accept Photo
5. CropImageActivity proceeds to crop image

Screenshots N/A

Smartphone (please complete the following information):

• Device: Emulator, Pixel 3a
• OS: API 30

Additional context Add any other context about the problem here.

• Lib Version : 2.2.2

After cropping image i found this issue that says Error: open failed: ENOENT (No such file or directory)

To Reproduce Steps to reproduce the behavior:

1. After setup library
2. Start CropImageActivity
3. Then crop image then it will show

Expected behavior In previous library of https://github.com/edmodo/cropper its working fine but in your library its showing above error

Screenshots

Smartphone :

• Device: Infinix note 7
• OS: 10

Android 10

Using Android Studio 3.6.3

I followed the steps as given but only camera and file options show up in the intent . The gallery option is not visible.I am also using the latest version of the library.

• Lib Version [e.g. 3.0.0]

Describe the bug First of all I would like to thank everyone involved in this library for the great work you have done. Well done.

I am currently using this library in a project where I have a personalized interface where the user can take a photo. When he takes the picture I take this uri and send it to another screen to edit the image. On this screen I have a button to crop the image, which is where I call the CropImage.

This is the contract:

fun createCropImageContract(uri: Uri): ActivityResultContract<Any?, Uri?> {
            return object : ActivityResultContract<Any?, Uri?>() {
                override fun createIntent(context: Context, input: Any?): Intent {
                    return CropImage
                        .activity(uri)
                        .getIntent(context)
                }

                override fun parseResult(resultCode: Int, intent: Intent?): Uri? {
                    return CropImage.getActivityResult(intent)?.uriContent
                }
            }
        }

However, when I call the method, the CropImage's Activity is called and is immediately closed returning the Uri as null.

This is what I was able to see in the log (I don't know if it's related but it appears every time I press the button) :

2021-04-14 09:48:08.723 3211-3211/? E/[IndicatorGarden]Presenter: onGardenApplyWindowInsets() New DisplayCutout is NULL!!
2021-04-14 09:48:08.725 3211-3211/? E/SystemUIImageView: set Image Drawable!!
2021-04-14 09:48:08.725 3211-3211/? E/SystemUIImageView: set Background Drawable!!
2021-04-14 09:48:08.729 3211-3211/? E/[IndicatorGarden]Presenter: onGardenApplyWindowInsets() New DisplayCutout is NULL!!
2021-04-14 09:48:08.786 3211-3211/? E/[IndicatorGarden]Presenter: onGardenApplyWindowInsets() New DisplayCutout is NULL!!
2021-04-14 09:48:08.788 3211-3211/? E/SystemUIImageView: set Image Drawable!!
2021-04-14 09:48:08.788 3211-3211/? E/SystemUIImageView: set Background Drawable!!
2021-04-14 09:48:08.792 3211-3211/? E/[IndicatorGarden]Presenter: onGardenApplyWindowInsets() New DisplayCutout is NULL!!

I have another feature which is the creation of a profile, there I call this contract and everything is working correctly:

fun createCropImageContract(): ActivityResultContract<Any?, Uri?> {
            return object : ActivityResultContract<Any?, Uri?>() {
                    override fun createIntent(context: Context, input: Any?): Intent {
                        return CropImage
                            .activity()
                            .getIntent(context)
                    }

                    override fun parseResult(resultCode: Int, intent: Intent?): Uri? {
                        return CropImage.getActivityResult(intent)?.uriContent
                    }
                }
        }

The problem is only when I already send Uri directly. Am I doing something wrong?

To Reproduce Call CropImage Passing the Uri from fragment:

CropImage
                        .activity(uri)
                        .getIntent(context)
                }

Expected behavior Open the CropImage activity to crop the provided Uri

Screenshots If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

• Pixel 2 XL Android 11
• Samsung Galaxy S9+ Android 10

Additional context

getting Null in intent data while clicking the image from the camera in Android 11 below in data i'm getting null in intent data @Override @SuppressLint("NewApi") protected void onActivityResult(int requestCode, int resultCode, Intent data) {

    // handle result of pick image chooser
    super.onActivityResult(requestCode, resultCode, data);
    if (requestCode == CropImage.PICK_IMAGE_CHOOSER_REQUEST_CODE) {
        if (resultCode == Activity.RESULT_CANCELED) {
            // User cancelled the picker. We don't have anything to crop
            setResultCancel();

        }

        if (resultCode == Activity.RESULT_OK) {
            mCropImageUri = CropImage.getPickImageResultUri(this, data);
            savedState.putString("mCropImageUri", mCropImageUri.toString());

            // For API >= 23 we need to check specifically that we have permissions to read external
            // storage.
            if (CropImage.isReadExternalStoragePermissionsRequired(this, mCropImageUri)) {
                // request permissions and handle the result in onRequestPermissionsResult()
                requestPermissions(
                        new String[]{Manifest.permission.READ_EXTERNAL_STORAGE},
                        CropImage.PICK_IMAGE_PERMISSIONS_REQUEST_CODE);
            } else {
                // no permissions required or already grunted, can start crop image activity
                mCropImageView.setImageUriAsync(mCropImageUri);
            }
        }
    } else {
        Toast.makeText(CropImageActivity.this, "Pressed Back", Toast.LENGTH_SHORT).show();
        finish();

    }

}

• Lib Version 3.3.6

Describe the bug setOnCropImageCompleteListener does not work Lambda function never gets called.

To Reproduce use the CropImageView, then: create a Lambda function:

binding.cropImageView.setOnCropImageCompleteListener{ view, result ->
    Log.d("imageComplete", "does this even get called")
}

notice that it never gets called when moving and scaling the crop region.

Expected behavior Lambda should get called when releasing the cropping rectangle so that the selected region can be automatically refreshed into i.E. a Preview Drawable

Media

Smartphone (please complete the following information):

• Device: Xiaomi Mix 2S and Pixel 4 Emulator
• OS: Android 10 MIUI 12.5 and Android 10 with Play Services

• Lib Version [e.g. 3.3.4-4.2.1]

Describe the bug I've upgraded the library and now I'm getting null bitmap in CropResult provided to the listener set using setOnCropImageCompleteListener. Interestingly isSuccessful is true and error is null.

The project is using CropImageView integration. The only change I needed to do when updating was to change getCroppedImageAsync() to croppedImageAsync().

The project is using Java 8, had issues upgrading it to Java 11. The files integrating with the library are in Kotlin. Not sure if it's not Java 8 issue but I would expect any such issues to be more likely build-time issues, not such an odd runtime issue of bitmap being null right at the end of the flow.

To Reproduce Steps to reproduce the behavior:

1. Use view integration
2. setOnCropImageCompleteListener
3. setImageBitmap
4. croppedImageAsync()

Expected behavior cropResult.bitmap provided to the listener should not be null

Please help/advise.

I was developing a feature where I need to rotate the image by a specific angle, but I realized that the rotateImage function wasn't working correctly, when I was aligning it to any side and trying to go back one or two degrees it didn't work correctly correct. I decided to see how it was being done and made the correction, I recorded two videos, the first is showing how it is currently and the second has already been corrected and working correctly.

before adjusting the method:

https://user-images.githubusercontent.com/90324370/207723300-12ecdf70-092d-4bd1-88b1-60ca77241880.mp4

after adjusting the method:

https://user-images.githubusercontent.com/90324370/207723267-0bc07486-5a05-406c-ba43-a6b2d0d9d131.mp4

I also noticed that it would be more interesting to change the parameter type from integer to float, in case someone wants to develop a feature using a range of values and these values have values of type float.

if you approve such changes, I can open a PR and it will have all the changes that were made

Hi! When configuring the CropImageContractOptions and setting allowFlipping = false I encountered a crash. Here's my code:

cropImage.launch(
            CropImageContractOptions(
                uri = null,
                cropImageOptions = CropImageOptions(
                    imageSourceIncludeGallery = true,
                    imageSourceIncludeCamera = true,
                    showIntentChooser = true,
                    toolbarColor = colorWhite,
                    toolbarBackButtonColor = colorBlack,
                    activityMenuTextColor = colorBlack,
                    activityMenuIconColor = colorBlack,
                    progressBarColor = colorAccent,
                    guidelinesColor = colorAccent,
                    borderCornerColor = colorAccent,
                    borderLineColor = colorAccent,
                    minCropResultHeight = resources.getDimensionPixelSize(R.dimen.photo_min_height),
                    minCropWindowWidth = binding.photoClImage.width,
                    allowFlipping = false
                )
            )
        )

And stacktrace:

java.lang.NullPointerException: Attempt to invoke interface method 'java.lang.CharSequence android.view.MenuItem.getTitle()' on a null object reference
                                                                                                    	at com.canhub.cropper.CropImageActivity.updateMenuItemTextColor(CropImageActivity.kt:454)
                                                                                                    	at com.canhub.cropper.CropImageActivity.onCreateOptionsMenu(CropImageActivity.kt:288)
                                                                                                    	at android.app.Activity.onCreatePanelMenu(Activity.java:4322)
                                                                                                    	at androidx.activity.ComponentActivity.onCreatePanelMenu(ComponentActivity.java:521)
                                                                                                    	at androidx.appcompat.view.WindowCallbackWrapper.onCreatePanelMenu(WindowCallbackWrapper.java:95)
                                                                                                    	at androidx.appcompat.app.AppCompatDelegateImpl$AppCompatWindowCallback.onCreatePanelMenu(AppCompatDelegateImpl.java:3122)
                                                                                                    	at androidx.appcompat.app.AppCompatDelegateImpl.preparePanel(AppCompatDelegateImpl.java:1913)
                                                                                                    	at androidx.appcompat.app.AppCompatDelegateImpl.doInvalidatePanelMenu(AppCompatDelegateImpl.java:2194)
                                                                                                    	at androidx.appcompat.app.AppCompatDelegateImpl$2.run(AppCompatDelegateImpl.java:276)
                                                                                                    	at android.os.Handler.handleCallback(Handler.java:938)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:99)
                                                                                                    	at android.os.Looper.loop(Looper.java:236)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:8057)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:620)

The library today already rotate images using 90, 180, 270 and 360 angles

The goal is to be able to rotate it by 1 degree difference.

For that will be need to auto zoom crop the image:

• Let's say the CropOverlay is the same size as the image.
• When we rotate 5 degrees it will be getting "outside" image area
• So is need to push the CropOverlay inside and create new limits

Add ui rotation selector, like a carrousel from 0-360