From TrendingView.java:

  toolbarView.setNavigationOnClickListener(new OnClickListener() {
      @Override public void onClick(View v) {
        // TODO bind to drawer with... injection?
      }
    });

How are you guys planning to implement this binding with MainActivity.drawerLayout?

Typically I'm doing this the following way: ActivityConnector binds to Activity livecycle with attach/detach (e.g. called from onStart/onStop), holds reference to some object in Activity. Simply it looks like this:

public class ActivityConnector<T> {
  private WeakReference<T> ref;

  public void attach(T obj) {
    ref = new WeakReference<T>(obj);
  }

  public void detach() {
    ref = null;
  }

  public T get() {
    return ref == null ? null : ref.get();
  }
}

More robust implementation can be found here.

This approach can be used to bind drawerLayout:

public final class MainActivity extends Activity {
  @Inject ActivityConnector<DrawerLayout> drawerConnector;

  @InjectView(R.id.main_drawer_layout) DrawerLayout drawerLayout;

  @Override protected void onStart() {
    super.onStart();
    drawerConnector.attach(drawerLayout);
  }

  @Override protected void onStop() {
    super.onStop();
    drawerConnector.detach();
  }
}

in TrendingView.java:

@Inject ActivityConnector<DrawerLayout> drawerConnector;
@InjectView(R.id.trending_toolbar) Toolbar toolbarView;

@Override protected void onFinishInflate() {
   super.onFinishInflate();
   ButterKnife.inject(this);

   toolbarView.setNavigationIcon(R.drawable.menu_icon);
   toolbarView.setNavigationOnClickListener(new OnClickListener() {
     @Override public void onClick(View v) {
       DrawerLayout drawer = drawerConnector.get();
       if (drawer != null) {
         drawerLayout.openDrawer(Gravity.START);
       }
     }
   });
}

What do you think about that?

Hi, I was wondering if it is possible to abstract out the Debug Drawer into a separate library that can be pulled into any app as a gradle dependency. In your sample, your are specifically using Dagger1, and there is a lot of code to look at just to understand how the debug drawer is implemented. I think it would be great if folks can use your implementation with any project (and Dagger2) without understanding all the separate classes that comprise the drawer.

Thanks, Igor

I got a error when run project .

Could you please help me solve this problem ? Tks

Error:(112, 0) Could not find method implementation() for arguments [com.android.support:support-v4:26.0.0-beta2] on object of type org.gradle.api.internal.artifacts.dsl.depend encies.DefaultDependencyHandler.

Please install the Android Support Repository from the Android SDK Manager. Open Android SDK Manager

Is there any possibility of adding to this app an example of how you switch back and forth between 2 custom views?

I've heard someone mention that Square doesn't use Fragments in their apps -- it would be nice to see an example in this app of how to handle multiple screens without Fragments.

I forked your library to showcase Mortar. I created this PR just in case you are interested in showcasing Mortar as well. Note that adding Flow would be easy too and can be done later when more than one screen would be used.

https://developer.android.com/reference/android/support/v7/widget/RecyclerView.Adapter.html#onBindViewHolder(VH,%20int)

The setHasStableIds(true); is unrelated but nice to have.

I struggle to find a good reference for how Dagger is used to inject dependencies in unit tests, especially when fragments and activities are involved.

I believe we're at our 3rd round of rewriting this in our app (we finally moved away completely from the clunky and verbose approach where you inject into the test class using a test module), and would be interested to see what Square suggests here.

FWIW: We went back to cutting out Dagger from unit tests and having @VisibleForTesting constructors on fragments, and then pass in mocks manually in unit tests. In the default ctor, the one Android would invoke, we then inject the object graph and have package visible fields with @Inject annotations. That introduces a weird split though between how dependencies are resolved (manually in tests, via Dagger in prod.)

It removes device configuration when emulator initializes. It causes the device to be 320x480 with 240 or 320 display density. Which makes effective screen width about 160dp. Emulator becomes almost useless. More info here. https://github.com/travis-ci/docs-travis-ci-com/pull/466

It looks like lint isn't happy with passing a raw number to res.getColor/getDimension

› ./gradlew assembleProductionRelease
:preBuild UP-TO-DATE
:preProductionReleaseBuild UP-TO-DATE
:checkProductionReleaseManifest
:preInternalDebugBuild UP-TO-DATE
:preInternalReleaseBuild UP-TO-DATE
:preProductionDebugBuild UP-TO-DATE
:prepareComAndroidSupportAppcompatV72301Library UP-TO-DATE
:prepareComAndroidSupportDesign2301Library UP-TO-DATE
:prepareComAndroidSupportRecyclerviewV72301Library UP-TO-DATE
:prepareComAndroidSupportSupportV42301Library UP-TO-DATE
:prepareComF2prateekRxPreferencesRxPreferences100Library UP-TO-DATE
:prepareComJakewhartonRxbindingRxbinding020Library UP-TO-DATE
:prepareComJakewhartonThreetenabpThreetenabp102Library UP-TO-DATE
:prepareComJakewhartonTimberTimber401Library UP-TO-DATE
:prepareComSquareupLeakcanaryLeakcanaryAndroidNoOp131Library UP-TO-DATE
:prepareIoReactivexRxandroid101Library UP-TO-DATE
:prepareProductionReleaseDependencies
:compileProductionReleaseAidl UP-TO-DATE
:compileProductionReleaseRenderscript UP-TO-DATE
:generateProductionReleaseBuildConfig
:generateProductionReleaseAssets UP-TO-DATE
:mergeProductionReleaseAssets UP-TO-DATE
:generateProductionReleaseResValues UP-TO-DATE
:generateProductionReleaseResources UP-TO-DATE
:mergeProductionReleaseResources UP-TO-DATE
:processProductionReleaseManifest UP-TO-DATE
:processProductionReleaseResources UP-TO-DATE
:generateProductionReleaseSources
:processProductionReleaseJavaRes UP-TO-DATE
:compileProductionReleaseJavaWithJavac
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:compileRetrolambdaProductionRelease
:compileProductionReleaseNdk UP-TO-DATE
:compileProductionReleaseSources
:lintVitalProductionRelease
/Users/mattm/Code/u2020/build/generated/source/apt/production/release/com/jakewharton/u2020/ui/MainActivity$$ViewBinder.java:19: Error: Expected resource of type color [ResourceType]
    target.statusBarColor = res.getColor(2131361859);
                                         ~~~~~~~~~~
/Users/mattm/Code/u2020/build/generated/source/apt/production/release/com/jakewharton/u2020/ui/trending/TrendingView$$ViewBinder.java:41: Error: Expected resource of type dimen [ResourceType]
    target.dividerPaddingStart = res.getDimension(2131099747);
                                                  ~~~~~~~~~~

   Explanation for issues of type "ResourceType":
   Ensures that resource id's passed to APIs are of the right type; for
   example, calling Resources.getColor(R.string.name) is wrong.

2 errors, 0 warnings
:lintVitalProductionRelease FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':lintVitalProductionRelease'.
> Lint found fatal errors while assembling a release target.

  To proceed, either fix the issues identified by lint, or modify your build script as follows:
  ...
  android {
      lintOptions {
          checkReleaseBuilds false
          // Or, if you prefer, you can continue to check for errors in release builds,
          // but continue the build even when errors are found:
          abortOnError false
      }
  }
  ...

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 15.452 secs

ShareCompat is used to always have good sharing Intent with necessary flags attached to it.

Here is the screenshots from old and new versions. In the old version you can see that Google Inbox app seems to be inside the screen of U+202 Internal.

| Old | New | | --- | --- | | | |

If you go to a second activity (ensuring that the previous activity is not destroyed), and change a setting in the debug drawer (such as latency), then go back to the first activity, the UI widgets in the debug drawer get out of sync with the preferences that back them since the widgets are only initialized in onCreate().

I've worked around this in my application by removing the @Singleton annotations from the DebugAppContainer class and the module that provides it, and adding a second method bind() so the interface for AppContainer looks like this:

ViewGroup get(Activity activity);
void bind(Activity activity);

Then I call bind() in onResume of my activity.

This adds a fair amount of complexity but is kind of necessary.

Please let me know if you're interested in a PR.

In DebugView, ProcessPhoenix.triggerRebirth seems to kill the process too fast. On my device, the SharedPreference won't get set, so I can't change the endpoint from the DebugView.

I got an error when run app! It showed could not find symbol. symbol: variable nullL, in u2020-master/app/src/internalDebug/java/com/jakewharton/u2020/ui/debug/DebugView.java

The debug drawer currently shows the available screen size, rather than the full screen size — it's useful to be able to see both. Also, show these sizes in dp as well as px, as these are the units we work in more often.

Setting endpoint to custom with value that is not parseable (e.g "saffga") will make the app crash. It will crash on every consequent startup until the app data is cleared. The reason is that the user inputed string is saved to @ApiEndpoint String preference, which is later read by provideHttpUrl method in DebugApiModule. The method tries to parse the String into HttpUrl but invalid Strings are parsed to null value. When null HttpUrl is provided as a base url when building retrofit instance, the app will crash.

Fix: Make sure user provided custom URL is parseable. Additional validation is required when custom endpoint is set by the user(within DebugView, check if it is parseable by HttpUrl.parse() method). I've made pull request for this but I guess I'm not allowed to push anything to this repo.