Description

Added the Excel to Pdf Fragment.

Fixes #186

Type of change

Just put an x in the [] which are valid.

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

• [x] ./gradlew assembleDebug assembleRelease
• [x] ./gradlew checkstyle

Checklist:

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings

As per Google Play’s target API level requirements, which states that -

New apps and app updates must target Android 10 (API level 29) or higher; except for Wear OS apps, which must target API level 28.

It is necessary to change targetSdkVersion from 28 to 29 or higher.

The first problem to do this :

Version 28 (intended for Android Pie and below) is the last version of the legacy support library. Because this project ( the app ) is using support library. It is the initial problem in order to update targetSdkVersion.

The solution for this initial problem :

As per Support Library Documentation, which states that -

With the release of Android 9.0 (API level 28) there is a new version of the support library called AndroidX which is part of Jetpack. The AndroidX library contains the existing support library and also includes the latest Jetpack components.

So, the project should be migrated from Support Library to AndroidX.

Is this solution enough?

As issue #973 and #989 comments that Image To PDF feature was stopped working after changing targetSdkVersion from 28 to 29, further work was to be done to resolves these mentioned issues.

Resolution of Issues #973 and #989 :

The problem is due to scoped storage concept of Google's new storage policy!

Problem? As Google's new storage policy states that -

To give users more control over their files and to limit file clutter, apps that target Android 10 (API level 29) and higher are given scoped access into external storage, or scoped storage, by default.

What is scoped storage? Scoped storage as its name suggest, it is the specific storage path or specific folder that user have chosen to save any data, files, etc.

Why google Introduced this storage policy? When WRITE_EXTERNAL_STORAGE permission is granted by user then the app get full access to the entire storage. It can do anything with any file in the storage ( except other app's private storage ). And by this behaviour, you can understand how danger this permission is if given to any bad app.

What exactly this policy say? Now, in API 29+, even if user granted WRITE_EXTERNAL_STORAGE permission, the app still not granted write access. Rather when the app wanted to write anything in the storage, the user will specifically have to choose a specific directory to save the file. It means app can't do anything with the storage without user's consent (neither can create folder nor can delete any).

What changed, Before policy vs After policy?

• Before, any app with WRITE_EXTERNAL_STORAGE permission can do anything with storage.
• Now, any app even with WRITE_EXTERNAL_STORAGE permission, can't do anything until user choose to give the permission to specific folder (SPECIFIC FOLDER NOT ENTIRE STORAGE).

More information at developer.android.com. Thus, implementing scoped storage method to save pdf or images to storage will fix #973 , fix #989

Type of change

• [x] targetSdkVersion updated to satisfy Google Play’s target API level requirements
• [x] compileSdkVersion updated as well
• [x] Bug fix

How Has This Been Tested?

• [x] ./gradlew assembleDebug assembleRelease
• [x] ./gradlew checkstyle

Successfully tested on :

• Android 9 Pie (Redmi 6A API 28) --Physical device
• Android 10 Q (Pixel 2 API 29) --Android Virtual Device(AVD)

Checklist:

• [x] Migrated to AndroidX
• [x] App targeted to API 30 (Thus satisfy Google requirement)
• [x] Solved scoped storage related issue in android 10 or higher ( api 29+)

Updated README.md

• Added GIF of updated UI in screenshot folder ( image_to_pdf2.gif )
• Delete GIF of previous UI in screenshot folder ( image_to_pdf.gif )

Additional note Closed #975 (redundant issue), because it is not closed by issue opener even after being resolved.

A note on resolution of scoped storage issue

• Optimized runtime permissions
• Removed unnecessary permissions
• Removed permission request from main activity because runtime permission should only be requested just before the action for which it is needed.
• Camera permission is only needed in Qr scanner activity, so removed from other activities and fragments
• In Api 29+, no permission is needed expect the camera permission ( keeping matisse library in exception because it only need READ_EXTERNAL_STORAGE permission.

Since this app can be considered as Document Management app . It comes under the permitted category to ask new special MANAGE_EXTERNAL_STORAGE permission.

What this special permission do?

• In simple words, This permission allows app to opt out of scoped storage permanently but android team will be checking regularly if the app should ask this permission or not.
• This permission is available for android 11 and above so to opt out of scoped storage in android 10/Q, there is a flag in manifest file requestLegacyExternalStorage must be true.

Fixes

• This PR fixes #1003, fixes #1009, fixes #1022, fixes #1028, fixes #1029
• Additionally, I suggest to close #1010 and close #1026 for proposing unwanted changes.

Tested on

• Redmi 6A (API 28) [Physical Device]
• Pixel 2 (API 29) [Android Emulator]
• Pixel 2 (API 30) [Android Emulator]

Description

updated realpath util method.

Fixes #679

Type of change

Just put an x in the [] which are valid.

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

• [x] ./gradlew assembleDebug assembleRelease
• [x] ./gradlew checkstyle

Checklist:

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings

What to do?

• Create a new section in the navigation drawer PPT to PDF
• Create similar UI as text to PDF
• The user should be able to select ppt & pptx files on clicking Select Files option
• Create PDF should be disabled when no file is selected
• On selecting, Creat PDF, a dialog should open up for filename
• If the filename does not exist already, create the PDF with the mentioned name
• Show the animation by the time PDF is getting created (similar to images to pdf option)
• After PDF is created, show a snackbar Your PDF is read, with an action Open file. On clicking that, the PDF should open up.

Reference:

https://github.com/yeokm1/docs-to-pdf-converter/blob/master/docs-to-pdf-converter/src/com/yeokhengmeng/docstopdfconverter/PptxToPDFConverter.java

Description

grayscale image is getting created, no error if we press cancel and other enhancement options are also working fine

Fixes #590

Type of change

Just put an x in the [] which are valid.

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

• [x] ./gradlew assembleDebug assembleRelease
• [x] ./gradlew checkstyle

Checklist:

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings

• Replace ViewFiles TextView with much more flexible RecyclerView
• Replace items with CardViews
• Add ScreenUtils for converting DIP to pixels depending on screen size
• Add ViewFilesDividerItemDecoration for decorating RecyclerView items
• Change FilesAdapter to extend RecyclerView.Adapter<RecyclerView.ViewHolder>
• Change ViewHolder to ViewFilesHolder for RecyclerView Adapter, declaring elements via Butterknife
• Structured and Cleaned Classes and Code
• Add Delete All Files option in file menu (will be changed to action bar option according to #47 )

Also Upgraded from current commit.

I have checked and test the recent commit, Creating a PDF file is working perfectly but facing an issue in Add Password, Merge PDF, Add Text, and others, Like showing "we are unable to access the file at this location" after selecting PDF file.

compileSdkVersion 30 buildToolsVersion '30.0.3' targetSdkVersion 30

java.lang.RuntimeException: An error occurred while executing doInBackground()
       at androidx.loader.content.ModernAsyncTask$3.done(ModernAsyncTask.java:164)
       at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:383)
       at java.util.concurrent.FutureTask.setException(FutureTask.java:252)
       at java.util.concurrent.FutureTask.run(FutureTask.java:271)
       at java.util.concurrent.ThreadPoolExecutor.processTask(ThreadPoolExecutor.java:1187)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1152)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
       at java.lang.Thread.run(Thread.java:929)
    Caused by: android.database.sqlite.SQLiteException: near "GROUP": syntax error (Sqlite code 1 SQLITE_ERROR): , while compiling: SELECT _id, bucket_id, bucket_display_name, _data, COUNT(*) AS count FROM files WHERE ((is_pending=0) AND (is_trashed=0) AND (volume_name IN ( 'external_primary' ))) AND (((media_type=? OR media_type=?) AND _size>0) GROUP BY (bucket_id)) ORDER BY datetaken DESC, (OS error - 2:No such file or directory)
       at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:184)
       at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:140)
       at android.content.ContentProviderProxy.query(ContentProviderNative.java:423)
       at android.content.ContentResolver.query(ContentResolver.java:955)
       at android.content.ContentResolver.query(ContentResolver.java:891)
       at androidx.core.content.ContentResolverCompat.query(ContentResolverCompat.java:81)
       at androidx.loader.content.CursorLoader.loadInBackground(CursorLoader.java:63)
       at com.zhihu.matisse.internal.loader.AlbumLoader.loadInBackground(AlbumLoader.java:97)
       at com.zhihu.matisse.internal.loader.AlbumLoader.loadInBackground(AlbumLoader.java:33)
       at androidx.loader.content.AsyncTaskLoader.onLoadInBackground(AsyncTaskLoader.java:307)
       at androidx.loader.content.AsyncTaskLoader$LoadTask.doInBackground(AsyncTaskLoader.java:60)
       at androidx.loader.content.AsyncTaskLoader$LoadTask.doInBackground(AsyncTaskLoader.java:48)
       at androidx.loader.content.ModernAsyncTask$2.call(ModernAsyncTask.java:141)
       at java.util.concurrent.FutureTask.run(FutureTask.java:266)

Description

Fixed App error on pdf to image for protected files.

Fixes #727

Type of change

Just put an x in the [] which are valid.

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

• [x] ./gradlew assembleDebug assembleRelease
• [x] ./gradlew checkstyle

Checklist:

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings

A new method is required in PermissionsUtils class and some minor refactors are required.

Bug Fix

After the implementation of PermissionsUtils class, onRequestPermissionsResult() is not getting executed in Fragment class. There's a workaround though.

• Modify the existing method as:

public static void requestRuntimePermissions(Object context, List<String> permissions,
                                                 int requestCode) {
        if (context instanceof Activity) {
            ActivityCompat.requestPermissions(((AppCompatActivity) context),
                    permissions.toArray(new String[permissions.size()]), requestCode);
        } else if (context instanceof Fragment) {
            ((Fragment) context).requestPermissions(permissions.toArray(new String[permissions.size()]),
                    requestCode);
        }
    }

• Introduce the new method:

 private static Context retrieveContext(Object context) {
        if (context instanceof AppCompatActivity)
            return ((AppCompatActivity) context).getApplicationContext();
        else
            return ((Fragment) context).requireActivity();
    }

• Use it wherever necessary like this: if ((ContextCompat.checkSelfPermission(retrieveContext(context),...
• Modify the function arguments as required for checkRuntimePermissions() to use Object instead of Activity as first argument.
• Update Javadoc comments.

Other Requirements

• Merge checkRuntimePermissions() and requestRuntimePermissions() methods (latter into former)
• Refactor checkRuntimePermissions() to requestRuntimePermissions()
• Create a new method checkRuntimePermissions() which returns true if the permission is granted and false if not.
• Modify Javadoc comments as required.
• Use PermissionsUtils in ZipToPdfFragment and TextToPdfFragment

If you are confused by above points, read them in order from top to bottom.

Would you like to work on the issue?

Tell us if you would like to work on this issue

Thanks to @Ni3verma for pointing it out. Since you have pointed it out, you are given a preference if you want to work on this issue.

I was taking a look at the app and noticed there are versions for various languages (Turkish, Korean, Spanish, etc). As a native Greek speaker, I would like to contirbute by adding a Greek Version.

Issue The Project is quite good, but it is quite old

Task I am planning to migrate the same project in new tech with clean Architecture. Planing to create project with below Tech

• Kotlin
• Jetpack Compose (UI)
• MVI Architecture
• Hilt Dependency Injection
• Complete testable code along with UI and Unit testing
• Flows
• Coroutines
• Other Jetpack Components

Motivation

• New Project will provide a resource for new and existing developers to get an understanding of using new technologies in Android
• New project will be more maintainable
• Will support latest Android Devices and SDK's as well
• Possibility of updating UI design
• Possibility of new features addition

For any ideas or suggestions, comment on the same thread

Description

This pull-request contains a quick fix on the itext library, in fact, the master branch was using the version 5.5.10 of the itext library containing lot of vulnerabilities. I changed the 5.5.10 old version to 5.5.13.3 version in the .gradle file.

Fixes #(issue) itext vulnerabilities issues fix.

Type of change

Just put an x in the [] which are valid.

• [x ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

• [x] ./gradlew assembleDebug assembleRelease
• [x] ./gradlew checkstyle

Checklist:

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings

Description

Added Marathi Locale. I have good command over Marathi and wanted to contribute to this project. I translated the string using google translate and personally checked every string.

Fixes #1014

Type of change

Just put an x in the [] which are valid.

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

• [ ] ./gradlew assembleDebug assembleRelease
• [ ] ./gradlew checkstyle

Checklist:

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings

Description

I have added the Nepali locale to the App. This will help to increase the reachability of this app for native Nepali people.

Fixes #(issue)

Type of change

Just put an x in the [] which are valid.

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

• [ ] ./gradlew assembleDebug assembleRelease
• [] ./gradlew checkstyle

Checklist:

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change. If there are any UI change, please include the screenshots also.

Fixes #1068

Type of change

Just put an x in the [] which are valid.

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

• [ ] ./gradlew assembleDebug assembleRelease
• [ ] ./gradlew checkstyle

Checklist:

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings