I tried using the library in xml according to the example and the image does not get cropped, it just shows the full image. I want the image to be cropped at the bottom. I tried any of the options, without any affect. How do I make it work in xml?

add a condition in order to avoid null pointers whenever we don't have an image set.

final Drawable image = getDrawable();
if (cropType != CropType.NONE && viewHeight > 0 && viewWidth > 0 && image != null) {
      final Matrix matrix = imageMaths.getMatrix();

      final int drawableWidth = image.getIntrinsicWidth();
      final int drawableHeight = image.getIntrinsicHeight();

 <com.cesards.cropimageview.CropImageView
                android:id="@+id/iv_profile_pic"
                android:layout_width="match_parent"
                android:layout_height="match_parent"
                android:foreground="@drawable/gradient_bottom_top"
                android:src="@drawable/add_profile_picbkg"
                app:crop="centerTop"
                /> 

This is what I get when I start activity: java.lang.NullPointerException: Attempt to invoke virtual method 'int android.graphics.drawable.Drawable.getIntrinsicWidth()' on a null object reference at com.cesards.cropimageview.CropImageView.computeImageMatrix(CropImageView.java:119) at com.cesards.cropimageview.CropImageView.setFrame(CropImageView.java:107) at android.view.View.layout(View.java:16648) at android.widget.RelativeLayout.onLayout(RelativeLayout.java:1079) at android.view.View.layout(View.java:16651) at android.view.ViewGroup.layout(ViewGroup.java:5440) at android.widget.FrameLayout.layoutChildren(FrameLayout.java:336) at android.widget.FrameLayout.onLayout(FrameLayout.java:273) at android.view.View.layout(View.java:16651) at android.view.ViewGroup.layout(ViewGroup.java:5440) at android.widget.RelativeLayout.onLayout(RelativeLayout.java:1079) at android.view.View.layout(View.java:16651) at android.view.ViewGroup.layout(ViewGroup.java:5440) at android.widget.FrameLayout.layoutChildren(FrameLayout.java:336) at android.widget.FrameLayout.onLayout(FrameLayout.java:273) at android.view.View.layout(View.java:16651) at android.view.ViewGroup.layout(ViewGroup.java:5440) at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1743) at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1586) at android.widget.LinearLayout.onLayout(LinearLayout.java:1495) at android.view.View.layout(View.java:16651) at android.view.ViewGroup.layout(ViewGroup.java:5440) at android.widget.FrameLayout.layoutChildren(FrameLayout.java:336) at android.widget.FrameLayout.onLayout(FrameLayout.java:273) at android.view.View.layout(View.java:16651) at android.view.ViewGroup.layout(ViewGroup.java:5440) at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1743) at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1586) at android.widget.LinearLayout.onLayout(LinearLayout.java:1495) at android.view.View.layout(View.java:16651) at android.view.ViewGroup.layout(ViewGroup.java:5440) at android.widget.FrameLayout.layoutChildren(FrameLayout.java:336) at android.widget.FrameLayout.onLayout(FrameLayout.java:273) at com.android.internal.policy.PhoneWindow$DecorView.onLayout(PhoneWindow.java:2678) at android.view.View.layout(View.java:16651) at android.view.ViewGroup.layout(ViewGroup.java:5440) at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:2183) at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:1943) at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1119) at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:6060) at android.view.Choreographer$CallbackRecord.run(Choreographer.java:858) at android.view.Choreographer.doCallbacks(Choreographer.java:670) at android.view.Choreographer.doFrame(Choreographer.java:606) at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:844) at android.os.Handler.handleCallback(Handler.java:746) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:148) at android.app.ActivityThread.main(ActivityThread.java:5443) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:728) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:618)

at com.cesards.cropimageview.CropImageView.computeImageMatrix(CropImageView.java:119)

causes crash if src is not specified in xml. So using an Image loading library does not work. would suggest to add a null-check for the drawable

update the document. Although I have tried to declare 'civ_crop' according to the document, however got complaining from the compiler. probably, the document is out of date.

I use Picasso to load my images but I need to use this library to correctly center my images but because this library extends FrameLayout and its imageView is private, I'm not able to use it. Any ways around this?

It closes #2

Added API 7 support to CropImageView. It doesn't make sense to add API 1 version even if ImageView API hasn't changed at all.

Sorry about styles boilerplate. I was unconscious and young.

2 :+1: needed

Adding the dependency compile 'com.cesards.android:cropimageview:1.0.2.1' to build.gradle(Module: app) causes RuntimeException. The App works fine on removing the dependency. Adding it again causes the app to crash as soon as it launches. I tried reproducing it three times and it occurred all the three times.

This closes #12

I found a very good answer to the problem here Before API 18, the setImageMatrix(Matrix matrix) is saving the matrix in a different field than getImageMatrix() is returning...

Android 4.4 ImageView

public void setImageMatrix(Matrix matrix) {
    // collaps null and identity to just null
    if (matrix != null && matrix.isIdentity()) {
        matrix = null;
    }

    // don't invalidate unless we're actually changing our matrix
    if (matrix == null && !mMatrix.isIdentity() ||
            matrix != null && !mMatrix.equals(matrix)) {
        mMatrix.set(matrix);
        configureBounds();
        invalidate();
    }
}

Here the matrix is being stored in the field mMatrix

public Matrix getImageMatrix() {
    if (mDrawMatrix == null) { //<-- should be mMatrix == null
        return new Matrix(Matrix.IDENTITY_MATRIX);
    }
    return mDrawMatrix; //<-- NOT THE RIGHT FIELD TO RETURN
}

While getImageMatrix() returns mDrawMatrix...

Android 4.1.2 ImageView

public Matrix getImageMatrix() {
    return mMatrix;
}

public void setImageMatrix(Matrix matrix) {
    // collaps null and identity to just null
    if (matrix != null && matrix.isIdentity()) {
        matrix = null;
    }

    // don't invalidate unless we're actually changing our matrix
    if (matrix == null && !mMatrix.isIdentity() ||
            matrix != null && !mMatrix.equals(matrix)) {
        mMatrix.set(matrix);
        configureBounds();
        invalidate();
    }
}

both methods use the same field - mMatrix

SOLUTION: preserve Matrix as field instead of retrieving it from ImageView in API < 18

It seems to me that the cropImageView don't rescale the image to respect the ScaleType. For example i'm using the CropImageView with a CENTER_CROP ScaleType. It works when opening the image but when a rotation (here I only tested with +-90°) is applied using CropImageView.rotateImage the image keep its size which is correct according to the initialization but not correct with respect to the rotation.

It closes #2

Added API 7 support to CropImageView. It doesn't make sense to add API 1 version even if ImageView API hasn't changed at all.

Sorry about styles boilerplate. I was unconscious and young.

2 :+1: needed

[BUG] 尊敬的开发者你好：

• Bug 1、 ImageCroppingActivity中Left Top crop of the horizontal image、Left Center crop of the horizontal image、Left Top crop of the horizontal image，发现三种裁剪和显示方式都是一样的。没有任何区别。 2、Right Top crop of the horizontal image、Right Center crop of the horizontal image、Right Top crop of the horizontal image三种裁剪和显示方式都是一样的，没有任何区别。 3、请检查是否裁剪算法错误。未实现标注的裁剪和显示方式 com.codeforvictory.android.superimageview.crop.ImageTransformation void compute(@CropType int cropType) { int viewWidth = view.getWidth() - view.getPaddingLeft() - view.getPaddingRight(); int viewHeight = view.getHeight() - view.getPaddingTop() - view.getPaddingBottom();

  if (cropType != CropType.NONE && viewHeight > 0 && viewWidth > 0) {
      Matrix matrix = compatMatrix.matrix(cropType);
  
      Drawable drawable = view.getDrawable();
      int drawableWidth = drawable.getIntrinsicWidth();
      int drawableHeight = drawable.getIntrinsicHeight();
  
      float scaleY = (float) viewHeight / (float) drawableHeight;
      float scaleX = (float) viewWidth / (float) drawableWidth;
      float scale = scaleX > scaleY ? scaleX : scaleY;
      matrix.setScale(scale, scale); // Same as doing matrix.reset() and matrix.preScale(...)
  
      boolean verticalImageMode = scaleX > scaleY;
  
      float xTranslation = getXTranslation(
          cropType,
          viewWidth,
          drawableWidth * scale,
          verticalImageMode
      );
      float yTranslation = getYTranslation(
          cropType,
          viewHeight,
          drawableHeight * scale,
          verticalImageMode
      );
  
      matrix.postTranslate(xTranslation, yTranslation);
      view.setImageMatrix(matrix);
  }
  

  }

jcenter is shutting down on May 1 https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/

Any chance this artifact can be uploaded to Maven Central before then?

This should supersede #28 due to the shutdown.

I came here because of

https://gist.github.com/arriolac/3843346#gistcomment-1395269

I just want a TopCropImageView.

The documentation suggests a "custom" namespace in xml such as

custom:crop="centerTop"

but the samples use really ugly app namespace with class references such as

				app:siv_cropImplementation="com.codeforvictory.android.superimageview.crop.CroppedImage"

Anyway, none of it is working out of the box. I think you need to clean up this library and documentation for it to be useful.

The documentation states that you should use com.codeforvictory.android.superimageview.SuperImageView for your view in xml. This didn't work for me and had to adjust it to com.cesards.cropimageview.CropImageView. I thought the docu should represent this correctly.

Currently we can choose to scale-crop from center (center crop) , from top, and other sides...

But what should I do to make it work for 20% from the top?

And what should be done to make it work for videos too?

I've asked about this here: https://stackoverflow.com/questions/54216273/how-to-have-similar-mechanism-of-center-crop-on-exoplayers-playerview-but-not/

Please, if you know how to do it, publish an answer. I will gladly grant the bounty if it works.