Hi,

Did some additional changes to my refactor based on feedback from Tim

The changes are in the branch 43-further-refactoring

This pull request does the necessary merging to get this and Tim's changes to TaskBag preferences + the "workofflinepref" bugfix into one pull.

In addition I set up so that local changes will be pushed to remote/dropbox when leaving offline mode.

Also removed the purging of local storage when signing out of dropbox, as per suggestion from Tim.

Sorry about having more than one commit here, but I felt it was needed to separate issues.

Gina,

Big fan of todo.txt and thought I could be a help to the project. I am really interested in building out the backend portion especially to allow completed items to push into done.txt.

This patch is my first step towards this effort. It moves a lot of Task related code into the Task object itself to avoid calling static methods on TaskHelper. I have created extensive unit tests for all the classes. One I would really like you to take a look at is TextSplitterTest.testSplit_outOfOrder. It appears that there may be a bug when the priority is in the middle of the text (e.g. "2001-01-01 (A) test". The priority is picked up but the prependedDate is not. It would seem that the date should definitely be picked up and the priority should be potentially ignored...but I didn't want to change existing functionality with the patch.

HTH and looking forward to adding more to the project, Tim

Right now when items are completed, an X is prepended to them and they still appear in the list of undone tasks.

Add support for done.txt:

• Sync done.txt as well as todo.txt on Sync
• When an item is marked as done in todo.txt, delete it and add it to done.txt and sync both files back to Dropbox

We could also add an "Archive" menu item that does this manually...

The dropbox v1 API will be shut down on 6/28/2017. (https://blogs.dropbox.com/developers/2016/06/api-v1-deprecated/) This means that any app which uses the old V1 API will stop to work.

For simpletask I am already looking into this (https://github.com/mpcjanssen/simpletask-android/issues/470) and the migration to V2 is certainly not trivial.

Holofied add task screen and included ActionBarSherlock This will unify the UI over all Android API versions resulting in code simplification.

NB: The lint.xml change is required, otherwise Eclipse will refuse to build with minSdk 4

I purchased todo.txtx on android and I keep getting the message when I select "File Location" "failed to load folder list from Dropbox"

I can't get any further and can't specify a location

Can anyone help please

Holo-ify all the things! Todo.txt should use the Holo theme for newer devices, and default to the original theme for older ones.

http://android-developers.blogspot.com/2012/01/holo-everywhere.html

@mpcjanssen is porting over the Holo work he did on Simpletask.

Update: Merged main task list and settings Holo-fication in 57e30c6f085b778db22435865772d3691a7d5745 and 2eeb408476836c8f8b81e9905a4a1edb31d3793c. Now must work on Add/Update Task screens.

Hi Gina, I added the new title bar with buttons, please see what you think about it. This Fixes #50.

I'm still having some issues with my repository, I apologize in advance if I messed anything up. I tried to squash my commits, but it said my working directory is dirty.. Whenever you have time, I would like to go over my repository with you and make sure I'm doing things correctly.

Hope you like the changes.

-Hrayr

Offline use

The app should function normally when your phone is offline, and sync back to Dropbox next time it has a network connection.

Corollary: completing actions shouldn't depend on the sync and be so slow; ideally sync will happen in the background.

Up until now Todo.txt has been written by dozens of programmers over several years, and on code review I didn't enforce any standard code style guidelines, which means our code isn't as readable or clean as it should be.

Standard code style makes code more readable and easier to maintain, so it's even more important for open source projects, which have multiple developers coming and going over time.

Let's start cleaning up our code to adhere to these published AOSP guidelines:

http://source.android.com/source/code-style.html

A few additional guidelines I'd like us to follow:

• Name string resources using all_lower_case_underscore_style
• Name all methods using camelCaseStartingWithLowercaseLetter. Methods that return booleans should start with is or has, ie, isThisCaseTrue or hasThisInformation

Rebased version of the beta38 drawerlayout changes. This pull request also removes the support lib copies from all the dependencies and makes them refer to the one in the main libs directory. This should prevent any future conflicts.

Hi, I was disappointed to see that todotxt asks for full access to the Dropbox account. Isn't it possible to enable either folder or specific access instead of full access?

see: Dropbox 3rd Party apps

Mostly complete update to Material Design, removing the old ActionBarSherlock dependencies, and moving most of the hard-coded styling into a Theme.

Still a few rough edges, and the tests need to be refactored for SDK > 26

This PR represents a working version against Dropbox v2, which should complete #481. I've only tested it on Android 7.0 at the moment, but was able to get it to load my todo, add tasks, and sync completions. The browsing for directory also works as tested in a limited fashion. This may be a bit of rough hack as I'm not fully versed in the event cycle of Android apps, but I tried to make as limited code changes as necessary to replace the functionality. Not sure what the next steps are from here, but I can build successfully and run by creating a dropbox.xml and commenting out the resValue for dropbox in the debug gradle configuration.

What I know needs to be handled/decided on:

• [ ] How to handle upgrades - I've only installed fresh on an old phone. Anything special that needs to be done.
• [ ] Signing the release version
• [ ] Dropbox API key to use - I created one for personal use/testing.
• [ ] Re-enable proguard if needed

I was having difficulty building the app after I made what I believed to be the upgrades to Dropbox code for v2 API. Since I haven't done Android development before and to isolate issues, I decided to put together a Dockerfile and clarify the build environment as I had miscellaneous tools installed and wasn't sure what was causing issues. I added back the necessary jars to build the original APK and worked through issues until I build the original APK from source and install it without issue. The following commands were used to build successfully:

docker build -t android-build .
docker run -it --rm --entrypoint="/bin/bash" android-build

# At the console prompt in the container
./gradlew assembleDebug

# From another free console, I copied out the apk
docker container ls
docker cp <container_name_from_previous_step>:/usr/src/app/app/build/outputs/apk/free/debug/ D:\tmp\todo.txt # change the output directory 'D:\tmp\todo.txt' to your preference.

I have a dropbox-v2 branch based off of this, which currently does not build, but I believe it is a matter of figuring out how to update the ActionBarSherlock activities with AppCompat as the new Dropbox SDK required enabling multiDexEnabled, which in turn required update Sdk versions to a minimum of 21. I also disabled Proguard as I wasn't able to get it to build with it enabled. Long story short, there may be other approaches to solving the issues listed above, but I figured the Docker image baselines the build environment and eliminates the individual system differences between developers.

Hi - the links in the README to purchase the app in both the Google Play store and Amazon Appstore are broken, and I couldn't find it in either by searching. Is the app still available in either of these stores? If so what are the current links? Or if not what is the recommended way to get it? Thanks :slightly_smiling_face: