Summary

Ensure that span flags are checked correctly.

❌ Incorrect spanned.getSpanFlags(span) == Spanned.INCLUSIVE_INCLUSIVE

✅ Correct spanned.getSpanFlags(span) and Spanned.SPAN_POINT_MARK_MASK == Spanned.INCLUSIVE_INCLUSIVE

❓ Why Spans flags may have priority bits or other bits set.

Requirements (place an x in each [ ])

• [x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
• [x] I've read and agree to the Code of Conduct.

The following point can be removed after setting up CI (such as Travis) with coverage reports (such as Codecov)

• [x] I've written tests to cover the new code and functionality included in this PR.

The following point can be removed after setting up a CLA reporting tool such as cla-assistant.io

• [x] I've read, agree to, and signed the Contributor License Agreement (CLA).

This adapts a DenyListedApiDetector that the folks at Cash App shared. Initially it uses (most) of their lints with some tweaks (rxjava 3 for instance). We can use this as a platform to add more of our own in the future too

Summary

Bump lint version to 30.4.0-alpha03

Requirements (place an x in each [ ])

• [x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
• [x] I've read and agree to the Code of Conduct.

The following point can be removed after setting up CI (such as Travis) with coverage reports (such as Codecov)

• [x] I've written tests to cover the new code and functionality included in this PR.

The following point can be removed after setting up a CLA reporting tool such as cla-assistant.io

• [x] I've read, agree to, and signed the Contributor License Agreement (CLA).

Summary

In order to better analyze our deprecated calls in lint reports, it would be helpful if reports identified the referenced deprecation. This PR prefixes the error message with the referenced deprecation when it is available.

Requirements (place an x in each [ ])

• [x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
• [x] I've read and agree to the Code of Conduct.

The following point can be removed after setting up CI (such as Travis) with coverage reports (such as Codecov)

• [x] I've written tests to cover the new code and functionality included in this PR.

The following point can be removed after setting up a CLA reporting tool such as cla-assistant.io

• [x] I've read, agree to, and signed the Contributor License Agreement (CLA).

Summary

Spans flags can have priority or other bits set. Ensure that Span flags are checked using currentFlag and Spanned.SPAN_POINT_MARK_MASK == desiredFlag rather than just currentFlag == desiredFlag

Requirements (place an x in each [ ])

• [x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
• [x] I've read and agree to the Code of Conduct.

The following point can be removed after setting up CI (such as Travis) with coverage reports (such as Codecov)

• [x] I've written tests to cover the new code and functionality included in this PR.

The following point can be removed after setting up a CLA reporting tool such as cla-assistant.io

• [x] I've read, agree to, and signed the Contributor License Agreement (CLA).

• JVM target 11
  • Required for latest lint
• Update to latest lint
  • Requires baselining some new test modes for now
• Prepare for maven central releases
• Switch to ktfmt + new simpler license header
• Align slack-lint naming with its artifact id - slack-lint-checks

This updates MissingResourceImportAliasDetector to use the module's package name instead of the file's to avoid false positives for modules with custom namespaces. It also updates the fix name for FullyQualifiedResourceDetector.

I found a vague reference in the sample lint config on this doc page that took me down a path to finding there's a new options API in lint for configuring lint detectors via the standard lint xml config.

This updates the inclusive naming linter to use that pattern, so now we would add this entry to our lint.xml to configure this instead. Much nicer 👍.

<?xml version="1.0" encoding="UTF-8"?>
<lint>
    <issue id="InclusiveNaming">
        <option name="block-list" value="fork,knife,spoon,spork"/>
    </issue>
</lint>

This adds 3 lint checks that enforce the rules around referencing resources in a non-transitive R class world:

• MissingResourceImportAliasDetector : enforces that only the local module's R class can be imported without an import alias.
• WrongResourceImportAliasDetector: enforces that the import aliases for R classes are consistent across the codebase.
• FullyQualifiedResourceDetector: enforces that R classes aren't referenced using their fully qualified names.

Best reviewed by commit.

| MissingResourceImportAliasDetector | WrongResourceImportAliasDetector | FullyQualifiedResourceDetector | | ----------- | ----------- | ----------- | |

We don't want folks to expose these types directly in the repository layer, it creates awkward situations where the UI suddenly has to know what to do about network failures as a state.

This updates our project to the latest lint APIs and also begins targeting building against latest. This should fix compatibility on newer studio versions + ease updates in the future by targeting latest (even while we still support lower versions).