Dear ionic-team,

After using Portals successfully in production for multiple weeks, I noticed hundreds of NullPointerExceptions in my sentry.io crash-reports. Specifically, a NullPointerException happened in the following line: https://github.com/ionic-team/ionic-portals/blob/main/android/IonicPortals/src/main/kotlin/io/ionic/portals/PortalFragment.kt#L99

Here is the stacktrace that was reported by sentry.io:

java.lang.NullPointerException: null at io.ionic.portals.PortalFragment.load(PortalFragment.kt:99) at io.ionic.portals.PortalFragment.onViewCreated(PortalFragment.kt:44) at androidx.fragment.app.Fragment.performViewCreated(Fragment.java:2987) at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:546) at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:282) at androidx.fragment.app.FragmentStore.moveToExpectedState(FragmentStore.java:112) at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1647) at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:3128) at androidx.fragment.app.FragmentManager.dispatchActivityCreated(FragmentManager.java:3072) at androidx.fragment.app.FragmentController.dispatchActivityCreated(FragmentController.java:251) at androidx.fragment.app.FragmentActivity.onStart(FragmentActivity.java:502) at androidx.appcompat.app.AppCompatActivity.onStart(AppCompatActivity.java:246) at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1435) at android.app.Activity.performStart(Activity.java:8231) at android.app.ActivityThread.handleStartActivity(ActivityThread.java:3853) at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:221) at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:201) at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:173) at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:97) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2317) at android.os.Handler.dispatchMessage(Handler.java:106) at android.os.Looper.loop(Looper.java:246) at android.app.ActivityThread.main(ActivityThread.java:8625) at java.lang.reflect.Method.invoke(Method.java) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:602) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1130)

I suspect that this happens when a PortalFragment gets instantiated without an instance of the Portal-class. For example, such erroneous instantiations might happen when the following empty default-constructor of a PortalFragment gets invoked: https://github.com/ionic-team/ionic-portals/blob/main/android/IonicPortals/src/main/kotlin/io/ionic/portals/PortalFragment.kt#L27

This makes me question whether there is a potential problem with Fragment-recreations. The Android-OS might destroy and recreate Fragments at any time, and this might trigger the NullPointerException.

Perhaps I could "fix" the bug by adding more null-checks to the problematic code, but my goal would be to find a root-cause instead of only adding null-checks.

This should allow for doing things like this:

type Messages = 
  | { topic: "cart:dismiss", data: "clear" | "cancel" }
  | { topic: "user:delete", data: User }

publish<Messages>({ topic: "cart:dismiss", data: "cancel" }) //totally fine
publish({ topic: "something:else", data: 1 }) // totally fine
publish<Messages>({ topic: "user:delete", data: "clear" }) // typescript error
publish<Messages>({ topic: "something:else", data: 1 }) // typescript error

Props to @eric-horodyski for the idea

Hi ionic team,

Our project is using ionic 3, cordova, Angular. I would like to know if we can use Portals, Our company is very interested in this feature: Micro Frontends with Module Federation, but did not find documentation and Demo for ionic Angular.

thanks!

Following the QuickStart guides, it seems like in iOS the web content is expected to be a Capacitor app? The same built web app works for Android.

Here's the error in the Xcode console:

⚡️ ERROR: Unable to find application directory at: "file:///private/var/containers/Bundle/Application/6C3DFA39-02A0-4878-A78B-3C3D535AD9EE/PortalsDemo.app/public"! Unable to find capacitor.config.json, make sure it exists and run npx cap copy. Unable to find config.xml, make sure it exists and run npx cap copy. 2022-06-15 12:11:53.660581-0700 PortalsDemo[5584:383934] [ViewportSizing] maximumViewportInset cannot be larger than frame 2022-06-15 12:11:53.660622-0700 PortalsDemo[5584:383934] [ViewportSizing] minimumViewportInset cannot be larger than frame ⚡️ ERROR: Unable to load /private/var/containers/Bundle/Application/6C3DFA39-02A0-4878-A78B-3C3D535AD9EE/PortalsDemo.app/public ⚡️ This file is the root of your web app and must exist before ⚡️ Capacitor can run. Ensure you've run capacitor copy at least ⚡️ or, if embedding, that this directory exists as a resource directory.

[!] Error installing IonicLiveUpdates [!] /usr/bin/git clone https://github.com/ionic-team/live-updates-sdk.git /var/folders/wp/yy92cy4j28q2m49vszqs4srm0000gn/T/d20220209-54213-1wln4g6 --template= --single-branch --depth 1

Cloning into '/var/folders/wp/yy92cy4j28q2m49vszqs4srm0000gn/T/d20220209-54213-1wln4g6'... remote: Repository not found. fatal: repository 'https://github.com/ionic-team/live-updates-sdk.git/' not found

This is a breaking change, but reduces the unnecessary asynchronous method by removing it from the plugin class and making it a separate function exported by the library.

Before:

Portals.getInitialContext<{ startingRoute: string }>().then((context) => {
  ReactDOM.render(
    <React.StrictMode>
      <App context={context.value} />
    </React.StrictMode>,
    document.getElementById('root'),
  );
});

After:

const initialContext = getInitialContext<{startingRoute: string}>();

ReactDOM.render(
  <React.StrictMode>
    <App context={initialContext.value} />
  </React.StrictMode>,
  document.getElementById('root'),
);

Update the "PortalsPlugin" and "Upgrade Guides" documentation to account for changes made in #166.

Once this is merged, I would like to request a release of @ionic/[email protected] 😄

Im using this gradle dependency: implementation("io.ionic:portals:0.5.0")

Gradle can compile build files but warns it missing dependecy to Cordova. I can however reference code from your lib.

When building app project, it fails, its complains about missing Cordova dependency.

> Could not resolve all files for configuration ':app:demoDebugRuntimeClasspath'.
   > Could not find org.apache.cordova:framework:7.0.0.
     Searched in the following locations:
       - https://dl.google.com/dl/android/maven2/org/apache/cordova/framework/7.0.0/framework-7.0.0.pom
       - https://repo.maven.apache.org/maven2/org/apache/cordova/framework/7.0.0/framework-7.0.0.pom
       - https://maven.shortcut.io/org/apache/cordova/framework/7.0.0/framework-7.0.0.pom
     Required by:
         project :app > io.ionic:portals:0.5.0 > com.capacitorjs:core:3.4.1

Am i missing any other dependencies or?

This allows Capacitor plugins to be registered with the bridge, for example: https://github.com/NativeScript/plugins/commit/644b896d8b5e3c5b8f89377e25b2797c2d50eb25#diff-8ccbf3f8847b6a1b15944609e0e0610409a8b5e910076d7298aeab62cd998e84R46

I’ve been trying to build the Portals iOS framework from source (due to issues using Cocoapods with my ObjC project) but have come across this…

In ‘PortalWebView.swift on line 64: ‘class InternalCapWebView: CAPWebView {‘

This line fails as ‘CAPWebView’ cannot be found and I cannot see anywhere this is defined (in Portals or Capacitor). Am I missing something? (e.g. a specific Capacitor version).

I assume it must be something I'm doing wrong as you must be able to build it there. Any help would be greatly appreciated.

While reading through the documentation to learn about Portals, I fixed some spelling errors and made some edits to make things more clear for non-native English speakers.